llvm7 #46888
Merged
llvm7 #46888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can all be squashed :). |
|
Also fixes #46854 . |
|
Fixing hashes shortly... |
|
Success on x86_64-linux (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
That's the least important part of this, borg! Haha. @GrahamcOfBorg build llvm_7 clang_7 |
|
Success on x86_64-darwin (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: llvm_7, clang_7 Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: llvm_7, clang_7 Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: llvm_7, clang_7 Partial log (click to expand)
|
dtzWill
force-pushed
the
feature/llvm-7
branch
from
1e47914
to
386d82e
Compare
|
Success on x86_64-darwin (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
Thanks for being on top of this, @dtzWill! Let's see which project can land this first, NixOS or Homebrew: Homebrew/homebrew-core#32233 🐎 🏁 |
|
FWIW, I think mostly this needs a Darwin tester, possibly someone to fixup the codesign patch but that might be something "anyone" can do. That said, having any actual in-tree users might help determine if things work or not :). |
LnL7
reviewed
Sep 20, 2018
There was a problem hiding this comment.
The darwin clang build fails with
Scanning dependencies of target clangd
[ 98%] Building CXX object tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o
[100%] Linking CXX executable ../../../../bin/clangd
ld: library not found for -latomic
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [tools/extra/clangd/tool/CMakeFiles/clangd.dir/build.make:109: bin/clangd] Error 1
make[1]: *** [CMakeFiles/Makefile2:8044: tools/extra/clangd/tool/CMakeFiles/clangd.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
|
Err :/. No idea why that'd be happening, don't suppose that's a "add darwin.libatomic as buildInput" sort of thing? Wishful thinking :). Rough that it happened at 98% hehe. Don't mean to be useless but not sure what to suggest for that.
I think compiler-rt has atomics, so maybe that's not being found or plumbed in properly...? Thanks for giving it a go, sorry about the result! |
|
Success on x86_64-darwin (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
Fwiw using mess built with this currently, nothing exploded yet ;). Might end up merging without Darwin support, let that get handled when someone with ability and interest finds it worth investigating. I expect it to be relatively simple TBH, but I'm excited for llvm7 goodness on master in the meantime :D. |
no complaints here; I have no use case for darwin support of llvm7 and I'm sure someone who does can pick up the work from here. |
Copy of 6 + updated hashes
Quite possibly this is not right.
Pretty sure they did last time too :).
See llvm 2a6cf85828509e89e18739e5f4b9a958820d66d4
dtzWill
force-pushed
the
feature/llvm-7
branch
from
f6c9c62
to
9fe245d
Compare
|
@GrahamcOfBorg build llvm_7 |
|
Failure on x86_64-darwin (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: llvm-manpages Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: llvm_7 Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: llvm_7 Partial log (click to expand)
|
|
I've been using mesa built with this-- so other than Darwin touchups I think this is good-to-go. Nothing depends on this yet, so merging so folks can test and projects can give it a try :). Apologies for any issues, can't promise I can fix them but please cc me if you encounter anything looking like a packaging problem. Thanks! |
Closed
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: llvm_7 Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches for darwin and musl need fixing,
and of course general testing :).
Fixes #46805.
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)