Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keras: fix build by updating expected dependencies. #45992

Merged
merged 1 commit into from Sep 3, 2018
Merged

Keras: fix build by updating expected dependencies. #45992

merged 1 commit into from Sep 3, 2018

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Sep 3, 2018

Keras: fix build by updating expected dependencies.

Motivation for this change

Keras expects keras_preprocessing 1.0.2 and 1.0.4. 1.0.3 and 1.0.5
are respectively in nixpkgs.

ZHF #45960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@danieldk
Keras: fix build by updating expected dependencies.
06cc85e 
Keras expects keras_preprocessing 1.0.2 and 1.0.4. 1.0.3 and 1.0.5
are respectively in nixpkgs.

ZHF NixOS#45960
@danieldk danieldk requested a review from FRidh as a code owner September 3, 2018 15:44
@FRidh
Copy link
Member

FRidh commented Sep 3, 2018

@GrahamcOfBorg build python3.pkgs.Keras

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python3.pkgs.Keras

Partial log (click to expand)

Requirement already satisfied: keras-applications==1.0.5 in /nix/store/zd3f802mvkvnwpc3kgphmm9087509wkq-python3.6-Keras_Applications-1.0.5/lib/python3.6/site-packages (from Keras==2.2.2) (1.0.5)
Requirement already satisfied: h5py in /nix/store/ycs37r6p6qj7aiwmpbrdjdjxz4xpc06j-python3.6-h5py-2.8.0/lib/python3.6/site-packages (from Keras==2.2.2) (2.8.0)
Installing collected packages: Keras
Successfully installed Keras-2.2.2
/private/tmp/nix-build-python3.6-Keras-2.2.2.drv-0/Keras-2.2.2
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/cml6a6rm0hlhqd5qa1c3kf47k47gy3cn-python3.6-Keras-2.2.2/lib
patching script interpreter paths in /nix/store/cml6a6rm0hlhqd5qa1c3kf47k47gy3cn-python3.6-Keras-2.2.2
/nix/store/cml6a6rm0hlhqd5qa1c3kf47k47gy3cn-python3.6-Keras-2.2.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3.pkgs.Keras

Partial log (click to expand)

Installing collected packages: Keras
Successfully installed Keras-2.2.2
/build/Keras-2.2.2
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/sdy0i28s1gcm68v843dmq2pbpvwm3444-python3.6-Keras-2.2.2
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sdy0i28s1gcm68v843dmq2pbpvwm3444-python3.6-Keras-2.2.2/lib
patching script interpreter paths in /nix/store/sdy0i28s1gcm68v843dmq2pbpvwm3444-python3.6-Keras-2.2.2
checking for references to /build in /nix/store/sdy0i28s1gcm68v843dmq2pbpvwm3444-python3.6-Keras-2.2.2...
/nix/store/sdy0i28s1gcm68v843dmq2pbpvwm3444-python3.6-Keras-2.2.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3.pkgs.Keras

Partial log (click to expand)

Installing collected packages: Keras
Successfully installed Keras-2.2.2
/build/Keras-2.2.2
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6sn75icdwmr3mkm24vkvap3r1n12jxmg-python3.6-Keras-2.2.2
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6sn75icdwmr3mkm24vkvap3r1n12jxmg-python3.6-Keras-2.2.2/lib
patching script interpreter paths in /nix/store/6sn75icdwmr3mkm24vkvap3r1n12jxmg-python3.6-Keras-2.2.2
checking for references to /build in /nix/store/6sn75icdwmr3mkm24vkvap3r1n12jxmg-python3.6-Keras-2.2.2...
/nix/store/6sn75icdwmr3mkm24vkvap3r1n12jxmg-python3.6-Keras-2.2.2

@xeji xeji merged commit e33be2a into NixOS:master Sep 3, 2018
xeji pushed a commit that referenced this pull request Sep 3, 2018
@danieldk @xeji
Keras: fix build by updating expected dependencies. (#45992)
08a86af 
Keras expects keras_preprocessing 1.0.2 and 1.0.4. 1.0.3 and 1.0.5
are respectively in nixpkgs.

ZHF #45960

(cherry picked from commit e33be2a)
@xeji
Copy link
Contributor

xeji commented Sep 3, 2018

backported in 08a86af

@danieldk danieldk deleted the keras-deps branch September 5, 2018 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danieldk @FRidh @GrahamcOfBorg @xeji