Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ultimate-oldschool-pc-font-pack: init at 1.0 #45969

Merged
merged 1 commit into from Sep 24, 2018
Merged

ultimate-oldschool-pc-font-pack: init at 1.0 #45969

merged 1 commit into from Sep 24, 2018

Conversation

endgame
Copy link
Contributor

@endgame endgame commented Sep 3, 2018

I'm not sure I've got everything 100% right; I haven't packaged fonts before. Also, I've only packaged the TTF fonts — is there anywhere useful I can put the bitmap .FON files?

Motivation for this change

I like my terminals to look like they came from 1990.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@lheckemann
Copy link
Member

@GrahamcOfBorg build ultimate-oldschool-pc-font-pack

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ultimate-oldschool-pc-font-pack

Partial log (click to expand)

configuring
no configure script, doing nothing
installing
/build
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/br3hzxh50krxxfbazcgli4mczv1zlvch-ultimate-oldschool-pc-font-pack-1.0
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/br3hzxh50krxxfbazcgli4mczv1zlvch-ultimate-oldschool-pc-font-pack-1.0
checking for references to /build in /nix/store/br3hzxh50krxxfbazcgli4mczv1zlvch-ultimate-oldschool-pc-font-pack-1.0...
/nix/store/br3hzxh50krxxfbazcgli4mczv1zlvch-ultimate-oldschool-pc-font-pack-1.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ultimate-oldschool-pc-font-pack

Partial log (click to expand)

setting SOURCE_DATE_EPOCH to timestamp 1452902400 of file ./README.NFO
patching sources
configuring
no configure script, doing nothing
installing
/private/tmp/nix-build-ultimate-oldschool-pc-font-pack-1.0.drv-0
post-installation fixup
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/g87vpb2wmbzvvwmx5wzsr1y9snxvybp8-ultimate-oldschool-pc-font-pack-1.0
/nix/store/g87vpb2wmbzvvwmx5wzsr1y9snxvybp8-ultimate-oldschool-pc-font-pack-1.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ultimate-oldschool-pc-font-pack

Partial log (click to expand)

configuring
no configure script, doing nothing
installing
/build
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/p4glz1l3zyb59gqcrvh1g9n3kjzddvbv-ultimate-oldschool-pc-font-pack-1.0
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/p4glz1l3zyb59gqcrvh1g9n3kjzddvbv-ultimate-oldschool-pc-font-pack-1.0
checking for references to /build in /nix/store/p4glz1l3zyb59gqcrvh1g9n3kjzddvbv-ultimate-oldschool-pc-font-pack-1.0...
/nix/store/p4glz1l3zyb59gqcrvh1g9n3kjzddvbv-ultimate-oldschool-pc-font-pack-1.0

@endgame
Copy link
Contributor Author

endgame commented Sep 24, 2018

Note that the .FON files are not packaged. sphalerite on IRC suggested the following resources for someone interested in packaging/converting the .FON files:

https://www.chiark.greenend.org.uk/~sgtatham/fonts/
http://fileformats.archiveteam.org/wiki/FON
http://www.seasip.info/Unix/PSF/

adisbladis
adisbladis reviewed Sep 24, 2018
View reviewed changes
pkgs/data/fonts/ultimate-oldschool-pc-font-pack/default.nix Outdated

installPhase = ''
mkdir -p $out/share/fonts/truetype
pwd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left over from debugging?

@endgame
Copy link
Contributor Author

endgame commented Sep 24, 2018

Yes. Removed, rebased against latest master and repushed.

@adisbladis
Copy link
Member

@GrahamcOfBorg build ultimate-oldschool-pc-font-pack

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ultimate-oldschool-pc-font-pack

Partial log (click to expand)

patching sources
configuring
no configure script, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/sp9d3gqhf8dd441n8v89nw2lfvd5ic4h-ultimate-oldschool-pc-font-pack-1.0
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/sp9d3gqhf8dd441n8v89nw2lfvd5ic4h-ultimate-oldschool-pc-font-pack-1.0
checking for references to /build in /nix/store/sp9d3gqhf8dd441n8v89nw2lfvd5ic4h-ultimate-oldschool-pc-font-pack-1.0...
/nix/store/sp9d3gqhf8dd441n8v89nw2lfvd5ic4h-ultimate-oldschool-pc-font-pack-1.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ultimate-oldschool-pc-font-pack

Partial log (click to expand)

source root is .
setting SOURCE_DATE_EPOCH to timestamp 1452902400 of file ./README.NFO
patching sources
configuring
no configure script, doing nothing
installing
post-installation fixup
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/37xa2xxkw7838xs14pk9lsa42scf55ac-ultimate-oldschool-pc-font-pack-1.0
/nix/store/37xa2xxkw7838xs14pk9lsa42scf55ac-ultimate-oldschool-pc-font-pack-1.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ultimate-oldschool-pc-font-pack

Partial log (click to expand)

updateAutotoolsGnuConfigScriptsPhase
configuring
no configure script, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1r6sn3hki891fhgf13rssnn7f7dw0m3c-ultimate-oldschool-pc-font-pack-1.0
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/1r6sn3hki891fhgf13rssnn7f7dw0m3c-ultimate-oldschool-pc-font-pack-1.0
checking for references to /build in /nix/store/1r6sn3hki891fhgf13rssnn7f7dw0m3c-ultimate-oldschool-pc-font-pack-1.0...
/nix/store/1r6sn3hki891fhgf13rssnn7f7dw0m3c-ultimate-oldschool-pc-font-pack-1.0

@adisbladis adisbladis merged commit a9d0b83 into NixOS:master Sep 24, 2018
@endgame endgame deleted the oldschool-pc-fonts branch September 24, 2018 07:26
@endgame endgame mentioned this pull request Sep 25, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@endgame @lheckemann @GrahamcOfBorg @adisbladis