Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitea: 1.5.0 -> 1.5.1 #45968

Merged
merged 1 commit into from Sep 3, 2018
Merged

gitea: 1.5.0 -> 1.5.1 #45968

merged 1 commit into from Sep 3, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Sep 3, 2018

Motivation for this change

Changelog: https://github.com/go-gitea/gitea/releases/tag/v1.5.1

Since it's security related fixes in there this should be backported to stable as well since stable was updated to 1.5.0 already (due to security related fixes as well).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 3, 2018

@GrahamcOfBorg build gitea

1 similar comment
@xeji
Copy link
Contributor

xeji commented Sep 3, 2018

@GrahamcOfBorg build gitea

@xeji
Copy link
Contributor

xeji commented Sep 3, 2018

@grahamc ofborg ignores me 😄 (well, everyone ...): I can see build jobs starting and finishing on Grafana, but no result on Github...

@xeji
Copy link
Contributor

xeji commented Sep 3, 2018

Let's try again

@GrahamcOfBorg build gitea

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: gitea

Partial log (click to expand)

building
no Makefile, doing nothing
installing
Building Go cmd/dist using /nix/store/29gizw0x73zc6zwgpxsiqcgid7sq57wx-go-bootstrap/share/go.
# _/nix/store/mm8wbc2ybpzy7azlxylv3wsl0c65hj6k-go-1.11/share/go/src/cmd/dist
2018/09/03 06:17:49 Invalid GOARM value. Must be 5, 6, or 7.
builder for '/nix/store/w0i02n2imx2wgifv6nqmhbhgz07fvp24-go-1.11.drv' failed with exit code 2
cannot build derivation '/nix/store/mwfnrw7y2cdqx46z4b5qkcyw81nd71wl-govers-20150109-3b5f175.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/fwmhia60610xnmqk9pg9qg0vf5w4s6va-gitea-1.5.1.drv': 2 dependencies couldn't be built
error: build of '/nix/store/fwmhia60610xnmqk9pg9qg0vf5w4s6va-gitea-1.5.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: gitea

Partial log (click to expand)

building
no Makefile, doing nothing
installing
Building Go cmd/dist using /nix/store/29gizw0x73zc6zwgpxsiqcgid7sq57wx-go-bootstrap/share/go.
# _/nix/store/mm8wbc2ybpzy7azlxylv3wsl0c65hj6k-go-1.11/share/go/src/cmd/dist
2018/09/03 06:41:40 Invalid GOARM value. Must be 5, 6, or 7.
builder for '/nix/store/w0i02n2imx2wgifv6nqmhbhgz07fvp24-go-1.11.drv' failed with exit code 2
cannot build derivation '/nix/store/mwfnrw7y2cdqx46z4b5qkcyw81nd71wl-govers-20150109-3b5f175.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/fwmhia60610xnmqk9pg9qg0vf5w4s6va-gitea-1.5.1.drv': 2 dependencies couldn't be built
error: build of '/nix/store/fwmhia60610xnmqk9pg9qg0vf5w4s6va-gitea-1.5.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitea

Partial log (click to expand)

checking for references to /build in /nix/store/0cj7l9rl1qssjck1djqf1w5cc4l3c3gv-gitea-1.5.1-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/q55bf9rlxylgc19jammawpk6gsh98vgb-gitea-1.5.1
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/q55bf9rlxylgc19jammawpk6gsh98vgb-gitea-1.5.1
checking for references to /build in /nix/store/q55bf9rlxylgc19jammawpk6gsh98vgb-gitea-1.5.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/1gd6ga0j6wzx993cyw5fmbagy3n752gk-gitea-1.5.1-data
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/1gd6ga0j6wzx993cyw5fmbagy3n752gk-gitea-1.5.1-data
checking for references to /build in /nix/store/1gd6ga0j6wzx993cyw5fmbagy3n752gk-gitea-1.5.1-data...
/nix/store/0cj7l9rl1qssjck1djqf1w5cc4l3c3gv-gitea-1.5.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitea

Partial log (click to expand)

checking for references to /build in /nix/store/0cj7l9rl1qssjck1djqf1w5cc4l3c3gv-gitea-1.5.1-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/q55bf9rlxylgc19jammawpk6gsh98vgb-gitea-1.5.1
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/q55bf9rlxylgc19jammawpk6gsh98vgb-gitea-1.5.1
checking for references to /build in /nix/store/q55bf9rlxylgc19jammawpk6gsh98vgb-gitea-1.5.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/1gd6ga0j6wzx993cyw5fmbagy3n752gk-gitea-1.5.1-data
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/1gd6ga0j6wzx993cyw5fmbagy3n752gk-gitea-1.5.1-data
checking for references to /build in /nix/store/1gd6ga0j6wzx993cyw5fmbagy3n752gk-gitea-1.5.1-data...
/nix/store/0cj7l9rl1qssjck1djqf1w5cc4l3c3gv-gitea-1.5.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gitea

Partial log (click to expand)

installing
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/6h4bjn9bxgdk2i1jmb6a9gpahwh6wh5p-gitea-1.5.1-bin/bin
patching script interpreter paths in /nix/store/6h4bjn9bxgdk2i1jmb6a9gpahwh6wh5p-gitea-1.5.1-bin
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/pwjslz4iwj1kd52wm64f0p7c8z0hf2hk-gitea-1.5.1
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/zbvy6vhqi0q81sz6l9lnlaay2yags7x7-gitea-1.5.1-data
/nix/store/6h4bjn9bxgdk2i1jmb6a9gpahwh6wh5p-gitea-1.5.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gitea

Partial log (click to expand)

/nix/store/6h4bjn9bxgdk2i1jmb6a9gpahwh6wh5p-gitea-1.5.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitea

Partial log (click to expand)

/nix/store/0cj7l9rl1qssjck1djqf1w5cc4l3c3gv-gitea-1.5.1-bin

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: gitea

Partial log (click to expand)

building
no Makefile, doing nothing
installing
Building Go cmd/dist using /nix/store/29gizw0x73zc6zwgpxsiqcgid7sq57wx-go-bootstrap/share/go.
# _/nix/store/mm8wbc2ybpzy7azlxylv3wsl0c65hj6k-go-1.11/share/go/src/cmd/dist
2018/09/03 07:36:12 Invalid GOARM value. Must be 5, 6, or 7.
builder for '/nix/store/w0i02n2imx2wgifv6nqmhbhgz07fvp24-go-1.11.drv' failed with exit code 2
cannot build derivation '/nix/store/mwfnrw7y2cdqx46z4b5qkcyw81nd71wl-govers-20150109-3b5f175.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/fwmhia60610xnmqk9pg9qg0vf5w4s6va-gitea-1.5.1.drv': 2 dependencies couldn't be built
error: build of '/nix/store/fwmhia60610xnmqk9pg9qg0vf5w4s6va-gitea-1.5.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: gitea

Partial log (click to expand)

building
no Makefile, doing nothing
installing
Building Go cmd/dist using /nix/store/29gizw0x73zc6zwgpxsiqcgid7sq57wx-go-bootstrap/share/go.
# _/nix/store/mm8wbc2ybpzy7azlxylv3wsl0c65hj6k-go-1.11/share/go/src/cmd/dist
2018/09/03 17:58:28 Invalid GOARM value. Must be 5, 6, or 7.
builder for '/nix/store/w0i02n2imx2wgifv6nqmhbhgz07fvp24-go-1.11.drv' failed with exit code 2
cannot build derivation '/nix/store/mwfnrw7y2cdqx46z4b5qkcyw81nd71wl-govers-20150109-3b5f175.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/fwmhia60610xnmqk9pg9qg0vf5w4s6va-gitea-1.5.1.drv': 2 dependencies couldn't be built
error: build of '/nix/store/fwmhia60610xnmqk9pg9qg0vf5w4s6va-gitea-1.5.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gitea

Partial log (click to expand)

/nix/store/6h4bjn9bxgdk2i1jmb6a9gpahwh6wh5p-gitea-1.5.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitea

Partial log (click to expand)

/nix/store/0cj7l9rl1qssjck1djqf1w5cc4l3c3gv-gitea-1.5.1-bin

@xeji
Copy link
Contributor

xeji commented Sep 3, 2018

actuall ofborg hit a github abuse detection mechanism because it posted too many comments 😄
aarch64 failure is unrelated, has been there before.

@xeji xeji merged commit fcccb9e into NixOS:master Sep 3, 2018
xeji pushed a commit that referenced this pull request Sep 3, 2018
@etu @xeji
gitea: 1.5.0 -> 1.5.1 (#45968)
d7cd099 
Changelog: https://github.com/go-gitea/gitea/releases/tag/v1.5.1
(cherry picked from commit fcccb9e)
xeji pushed a commit that referenced this pull request Sep 3, 2018
@etu @xeji
gitea: 1.5.0 -> 1.5.1 (#45968)
45f52f7 
Backported because of security fixes.
Changelog: https://github.com/go-gitea/gitea/releases/tag/v1.5.1
(cherry picked from commit fcccb9e)
@xeji
Copy link
Contributor

xeji commented Sep 3, 2018

backported to 18.09 in d7cd099
and to 18.03 in 45f52f7
cc @aanderse

@etu etu deleted the upgrade-gitea branch September 3, 2018 18:39
@etu
Copy link
Contributor Author

etu commented Sep 3, 2018

@xeji Maybe I should disable gitea on aarch64... :)

@aanderse aanderse mentioned this pull request Nov 6, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@etu @xeji @GrahamcOfBorg @vcunat