emacs: allow X and cli-only builds on Darwin #45988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefloweringash
force-pushed
the
emacs-darwin-cli
branch
from
58674ee
to
d871163
Compare
|
++ lib.optionals withX
[ xlibsWrapper libXaw Xaw3d libXpm libpng libjpeg libungif libtiff librsvg libXft
- imagemagick gconf m17n_lib libotf ]
+ imagemagick gconf ]
+ ++ lib.optionals (stdenv.isLinux && withX) [ m17n_lib libotf ]
++ lib.optional (withX && withGTK2) gtk2
++ lib.optionals (withX && withGTK3) [ gtk3 gsettings-desktop-schemas ]
This looks strange to me. Can you build withX on Darwin?
Also /cc @matthewbauer
|
|
Yep x11 can work on macOS. I think it isn’t used much but might be useful for things like xwidgets and stuff. |
thefloweringash
force-pushed
the
emacs-darwin-cli
branch
from
d871163
to
b899880
Compare
|
After reading your comments, I had another look at the gtk2/gtk3 support in emacs. It seems like if building against gtk, it must be X11 gtk. I've pushed an updated version of the patch to use |
thefloweringash
force-pushed
the
emacs-darwin-cli
branch
from
b899880
to
2e196a4
Compare
thefloweringash
force-pushed
the
emacs-darwin-cli
branch
from
2e196a4
to
bbf37b8
Compare
|
What's the cause of the |
|
I think it just calls anything that’s not a new package a clean up. |
|
@GrahamcOfBorg build emacs |
|
Success on x86_64-darwin (full log) Attempted: emacs Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: emacs Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: emacs Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It's possible to configure Emacs on Darwin to build as CLI-only, with lucid, or with Cocoa. Nixpkgs currently does not allow this configuration, and always forces building with Cocoa.
Based on the assertions, building with GTK2 and GTK3 (without X11?) is supported on macOS, but the
buildInputsvalue doesn't seem to match this, and only provides gtk ifwithX = true. As is, trying to build withwithX = true; withGTK2 = true;orwithX = true; withGTK3 = true;does not succeed.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)