Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] Revert "arrow-cpp: 0.9.0 -> 0.10.0" #45991

Merged
merged 1 commit into from Sep 3, 2018
Merged

[18.09] Revert "arrow-cpp: 0.9.0 -> 0.10.0" #45991

merged 1 commit into from Sep 3, 2018

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Sep 3, 2018 •
edited

Hold off the upgrade until parquet 1.5.0 is released.

This reverts commit 72d6307.

(cherry picked from commit 992d64b)

Motivation for this change

Fixes parquet-cpp for 18.09. PR against master is #45990

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@veprbl
Revert "arrow-cpp: 0.9.0 -> 0.10.0"
855a985 
Hold off the upgrade until parquet 1.5.0 is released.

This reverts commit 72d6307.

(cherry picked from commit 992d64b)
@veprbl
Copy link
Member Author

veprbl commented Sep 3, 2018

ZHF #45960

@veprbl
Copy link
Member Author

veprbl commented Sep 3, 2018

Check if there is any remaining issues:
@GrahamcOfBorg build arrow-cpp python2Packages.pyarrow python3Packages.pyarrow parquet-cpp

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: arrow-cpp, python2Packages.pyarrow, python3Packages.pyarrow, parquet-cpp

Partial log (click to expand)

    self.module)
  File "/nix/store/s9mj8zzg7b0zj7s0k4rx3hdsiayr3ckn-python-2.7.15/lib/python2.7/unittest/loader.py", line 130, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/nix/store/s9mj8zzg7b0zj7s0k4rx3hdsiayr3ckn-python-2.7.15/lib/python2.7/unittest/loader.py", line 91, in loadTestsFromName
    module = __import__('.'.join(parts_copy))
  File "/private/tmp/nix-build-python2.7-pyarrow-0.9.0.drv-0/apache-arrow-0.9.0/python/pyarrow/__init__.py", line 47, in <module>
    from pyarrow.lib import cpu_count, set_cpu_count
ImportError: No module named lib
builder for '/nix/store/bznmjssxzn2pbgcl7fsn7dhpdss388w1-python2.7-pyarrow-0.9.0.drv' failed with exit code 1
error: build of '/nix/store/7g931lp1rj1fhcwppwrhm5jhnyp56jb1-python3.6-pyarrow-0.9.0.drv', '/nix/store/bznmjssxzn2pbgcl7fsn7dhpdss388w1-python2.7-pyarrow-0.9.0.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: arrow-cpp, python2Packages.pyarrow, python3Packages.pyarrow, parquet-cpp

Partial log (click to expand)

../../nix/store/8j80sfr6rmn7yd161v1f0f1zqm28b1g6-python3.6-pandas-0.23.4/lib/python3.6/site-packages/pandas/tests/dtypes/test_inference.py . [ 11%]
........................................................................ [ 12%]
........................................................................ [ 12%]
......................................................................   [ 12%]
../../nix/store/8j80sfr6rmn7yd161v1f0f1zqm28b1g6-python3.6-pandas-0.23.4/lib/python3.6/site-packages/pandas/tests/dtypes/test_missing.py . [ 12%]
..........................................                               [ 13%]
../../nix/store/8j80sfr6rmn7yd161v1f0f1zqm28b1g6-python3.6-pandas-0.23.4/lib/python3.6/site-packages/pandas/tests/frame/test_alter_axes.py . [ 13%]
building of '/nix/store/ayrh1lcxh7jv2j9nccqhb5gxlkq4z4c5-python3.6-pandas-0.23.4.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/wpvkgpkfj82yf216mq9bw1b2mzsmgf0h-python3.6-pyarrow-0.9.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/2z483l1hkwvmmv2327g3lqw5rklqkx6n-python2.7-pyarrow-0.9.0.drv', '/nix/store/wpvkgpkfj82yf216mq9bw1b2mzsmgf0h-python3.6-pyarrow-0.9.0.drv' failed

@xeji
Copy link
Contributor

xeji commented Sep 3, 2018

let's start the build again, x86_64-linux got lost somehow
@GrahamcOfBorg build arrow-cpp python2Packages.pyarrow python3Packages.pyarrow parquet-cpp

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: arrow-cpp, python2Packages.pyarrow, python3Packages.pyarrow, parquet-cpp

Partial log (click to expand)



----------------------------------------------------------------------
Ran 1 test in 0.000s

FAILED (errors=1)
Test failed: <unittest.runner.TextTestResult run=1 errors=1 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=1 errors=1 failures=0>
builder for '/nix/store/7g931lp1rj1fhcwppwrhm5jhnyp56jb1-python3.6-pyarrow-0.9.0.drv' failed with exit code 1
error: build of '/nix/store/7g931lp1rj1fhcwppwrhm5jhnyp56jb1-python3.6-pyarrow-0.9.0.drv', '/nix/store/bznmjssxzn2pbgcl7fsn7dhpdss388w1-python2.7-pyarrow-0.9.0.drv' failed

@xeji
Copy link
Contributor

xeji commented Sep 3, 2018

pyarrow actually never built on darwin according to hydra logs, https://hydra.nixos.org/job/nixpkgs/trunk/python27Packages.pyarrow.x86_64-darwin/all , so let's ignore that for now.

@veprbl
Copy link
Member Author

veprbl commented Sep 3, 2018

@xeji Yes, I'm aware. It builds on my machine somehow. I haven't had a chance to investigate the issue (given I can't reproduce).

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: arrow-cpp, python2Packages.pyarrow, python3Packages.pyarrow, parquet-cpp

Partial log (click to expand)

Moving built C-extension release/lib.cpython-36m-x86_64-linux-gnu.so to build path /build/apache-arrow-0.9.0/python/pyarrow/lib.cpython-36m-x86_64-linux-gnu.so
Moving built C-extension release/_parquet.cpython-36m-x86_64-linux-gnu.so to build path /build/apache-arrow-0.9.0/python/pyarrow/_parquet.cpython-36m-x86_64-linux-gnu.so
release/_orc.cpython-36m-x86_64-linux-gnu.so
Cython module _orc failure permitted
release/plasma.cpython-36m-x86_64-linux-gnu.so
Cython module plasma failure permitted
/nix/store/0clh1cw6aifz03ryj9bk3a0fvwcwzv5k-arrow-cpp-0.9.0
/nix/store/r3j3hbm5q8vj1fpjp3s0l5k5hdjbdbdy-python2.7-pyarrow-0.9.0
/nix/store/wf8asgp0qc0gnnim3l71wci5ckg27p3a-python3.6-pyarrow-0.9.0
/nix/store/p293a679zvp7fsw2s400lvvbi9mfzrs2-parquet-cpp-1.4.0

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: arrow-cpp, python2Packages.pyarrow, python3Packages.pyarrow, parquet-cpp

Partial log (click to expand)

  /nix/store/8j80sfr6rmn7yd161v1f0f1zqm28b1g6-python3.6-pandas-0.23.4/lib/python3.6/site-packages/pandas/core/internals.py:312: FutureWarning: Using a non-tuple sequence for multidimensional indexing is deprecated; use `arr[tuple(seq)]` instead of `arr[seq]`. In the future this will be interpreted as an array index, `arr[np.array(seq)]`, which will result either in an error or a different result.
    return self.values[slicer]
  /nix/store/8j80sfr6rmn7yd161v1f0f1zqm28b1g6-python3.6-pandas-0.23.4/lib/python3.6/site-packages/pandas/core/indexes/datetimelike.py:428: FutureWarning: Using a non-tuple sequence for multidimensional indexing is deprecated; use `arr[tuple(seq)]` instead of `arr[seq]`. In the future this will be interpreted as an array index, `arr[np.array(seq)]`, which will result either in an error or a different result.
    result = getitem(key)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
 5 failed, 16897 passed, 1027 skipped, 11896 deselected, 37 xfailed, 2 xpassed, 10 warnings in 1549.58 seconds
builder for '/nix/store/ayrh1lcxh7jv2j9nccqhb5gxlkq4z4c5-python3.6-pandas-0.23.4.drv' failed with exit code 1
cannot build derivation '/nix/store/wpvkgpkfj82yf216mq9bw1b2mzsmgf0h-python3.6-pyarrow-0.9.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/2z483l1hkwvmmv2327g3lqw5rklqkx6n-python2.7-pyarrow-0.9.0.drv', '/nix/store/wpvkgpkfj82yf216mq9bw1b2mzsmgf0h-python3.6-pyarrow-0.9.0.drv' failed

@xeji
Copy link
Contributor

xeji commented Sep 3, 2018

aarch64 failure looks unrelated. @veprbl is this ok to merge now?

@veprbl
Copy link
Member Author

veprbl commented Sep 3, 2018

@xeji Yes, absolutely.

@xeji xeji merged commit 6c988bc into NixOS:release-18.09 Sep 3, 2018
@veprbl veprbl deleted the pr/arrow-cpp_0.9.0_rollback_18.09 branch September 3, 2018 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @GrahamcOfBorg @xeji