Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "arrow-cpp: 0.9.0 -> 0.10.0" #45990

Merged
merged 1 commit into from Sep 3, 2018
Merged

Revert "arrow-cpp: 0.9.0 -> 0.10.0" #45990

merged 1 commit into from Sep 3, 2018

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Sep 3, 2018 •
edited

Hold off the upgrade until parquet 1.5.0 is released.

This reverts commit 72d6307.

Motivation for this change

The new arrow-cpp breaks parquet-cpp.

When originally bumping arrow-cpp, I saw that both AUR and Homebrew already had arrow 0.10.0, but what I did not realise was that Homebrew doesn't provide parquet-cpp and AUR had it broken after the bump [1]

[1] See comment in https://aur.archlinux.org/packages/parquet-cpp

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@veprbl
Revert "arrow-cpp: 0.9.0 -> 0.10.0"
992d64b 
Hold off the upgrade until parquet 1.5.0 is released.

This reverts commit 72d6307.
@veprbl veprbl mentioned this pull request Sep 3, 2018
Merged
9 tasks
@xeji
Copy link
Contributor

xeji commented Sep 3, 2018

@GrahamcOfBorg build arrow-cpp

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: arrow-cpp

Partial log (click to expand)

/nix/store/4qsgrhqd8l112z8jfx4ab6784d6ikia3-arrow-cpp-0.9.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: arrow-cpp

Partial log (click to expand)

/nix/store/vg5m9bx3wvm1kfxjagaksgqz991z6wv4-arrow-cpp-0.9.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: arrow-cpp

Partial log (click to expand)

/nix/store/0clh1cw6aifz03ryj9bk3a0fvwcwzv5k-arrow-cpp-0.9.0

@xeji xeji merged commit f46d239 into NixOS:master Sep 3, 2018
@veprbl veprbl deleted the pr/arrow-cpp_0.9.0_rollback branch September 3, 2018 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @xeji @GrahamcOfBorg