Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imv: 2.1.3 -> 3.0.0 #45976

Merged
merged 2 commits into from Sep 3, 2018
Merged

imv: 2.1.3 -> 3.0.0 #45976

merged 2 commits into from Sep 3, 2018

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Sep 3, 2018

Motivation for this change

Version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change
  • Tested compilation of all pkgs that depend on this change (none)
  • Tested execution of all binary files
  • Determined the impact on package closure size (1.1x)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: imv

Partial log (click to expand)

gcc -c -W -Wall -pedantic -Wmissing-prototypes -std=c99 -DIMV_VERSION=\""v3.0.0"\" -I/nix/store/2sdqmqgmhmkr4h2y25cs0v2a9w540y4y-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/2sdqmqgmhmkr4h2y25cs0v2a9w540y4y-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/8l9wmyxkrdpygcj2s2613ckfkg8wvbl0-SDL2_ttf-2.0.14/include/SDL2 -I/nix/store/2sdqmqgmhmkr4h2y25cs0v2a9w540y4y-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/8l9wmyxkrdpygcj2s2613ckfkg8wvbl0-SDL2_ttf-2.0.14/include/SDL2 -D_REENTRANT -D_XOPEN_SOURCE=700 -o build/list.o src/list.c
gcc -c -W -Wall -pedantic -Wmissing-prototypes -std=c99 -DIMV_VERSION=\""v3.0.0"\" -I/nix/store/2sdqmqgmhmkr4h2y25cs0v2a9w540y4y-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/2sdqmqgmhmkr4h2y25cs0v2a9w540y4y-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/8l9wmyxkrdpygcj2s2613ckfkg8wvbl0-SDL2_ttf-2.0.14/include/SDL2 -I/nix/store/2sdqmqgmhmkr4h2y25cs0v2a9w540y4y-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/8l9wmyxkrdpygcj2s2613ckfkg8wvbl0-SDL2_ttf-2.0.14/include/SDL2 -D_REENTRANT -D_XOPEN_SOURCE=700 -o build/ini.o src/ini.c
gcc -c -W -Wall -pedantic -Wmissing-prototypes -std=c99 -DIMV_VERSION=\""v3.0.0"\" -I/nix/store/2sdqmqgmhmkr4h2y25cs0v2a9w540y4y-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/2sdqmqgmhmkr4h2y25cs0v2a9w540y4y-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/8l9wmyxkrdpygcj2s2613ckfkg8wvbl0-SDL2_ttf-2.0.14/include/SDL2 -I/nix/store/2sdqmqgmhmkr4h2y25cs0v2a9w540y4y-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/8l9wmyxkrdpygcj2s2613ckfkg8wvbl0-SDL2_ttf-2.0.14/include/SDL2 -D_REENTRANT -D_XOPEN_SOURCE=700 -o build/loader.o src/loader.c
gcc -c -W -Wall -pedantic -Wmissing-prototypes -std=c99 -DIMV_VERSION=\""v3.0.0"\" -I/nix/store/2sdqmqgmhmkr4h2y25cs0v2a9w540y4y-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/2sdqmqgmhmkr4h2y25cs0v2a9w540y4y-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/8l9wmyxkrdpygcj2s2613ckfkg8wvbl0-SDL2_ttf-2.0.14/include/SDL2 -I/nix/store/2sdqmqgmhmkr4h2y25cs0v2a9w540y4y-SDL2-2.0.8-dev/include/SDL2 -I/nix/store/8l9wmyxkrdpygcj2s2613ckfkg8wvbl0-SDL2_ttf-2.0.14/include/SDL2 -D_REENTRANT -D_XOPEN_SOURCE=700 -o build/commands.o src/commands.c
gcc -o build/imv build/bitmap.o build/navigator.o build/image.o build/imv.o build/binds.o build/util.o build/main.o build/viewport.o build/list.o build/ini.o build/loader.o build/commands.o -L/nix/store/nw93fdrg84lcmkvkj9kf03x5y3rbhn24-SDL2-2.0.8/lib -Wl,-rpath,/nix/store/nw93fdrg84lcmkvkj9kf03x5y3rbhn24-SDL2-2.0.8/lib -Wl,--enable-new-dtags -lSDL2 -lfreeimage -lSDL2_ttf -lfontconfig -lpthread
/nix/store/73y29dnrscrhsg0fzqnj1w0dbrq69flz-freeimage-3.17.0/lib/libfreeimage.so: undefined reference to `png_init_filter_functions_neon'
collect2: error: ld returned 1 exit status
make: *** [Makefile:30: build/imv] Error 1
builder for '/nix/store/lhn64j088vwlq7xpm3g9mcvvfakvkm5z-imv-3.0.0.drv' failed with exit code 2
error: build of '/nix/store/lhn64j088vwlq7xpm3g9mcvvfakvkm5z-imv-3.0.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: imv

Partial log (click to expand)

src/navigator.c:275:48: error: no member named 'st_mtim' in 'struct stat'
    if(nav->mtimes[nav->cur_path] != file_info.st_mtim.tv_sec) {
                                     ~~~~~~~~~ ^
src/navigator.c:276:46: error: no member named 'st_mtim' in 'struct stat'
      nav->mtimes[nav->cur_path] = file_info.st_mtim.tv_sec;
                                   ~~~~~~~~~ ^
4 errors generated.
make: *** [Makefile:41: build/navigator.o] Error 1
builder for '/nix/store/z9cxxhjbr80is20isamd859sll8xlgvx-imv-3.0.0.drv' failed with exit code 2
error: build of '/nix/store/z9cxxhjbr80is20isamd859sll8xlgvx-imv-3.0.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: imv

Partial log (click to expand)

install -D -m 0644 files/imv_config /nix/store/xmskm3znbsk7m46g3ds0z79jdmdc7fbj-imv-3.0.0/etc/imv_config
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xmskm3znbsk7m46g3ds0z79jdmdc7fbj-imv-3.0.0
shrinking /nix/store/xmskm3znbsk7m46g3ds0z79jdmdc7fbj-imv-3.0.0/bin/imv
gzipping man pages under /nix/store/xmskm3znbsk7m46g3ds0z79jdmdc7fbj-imv-3.0.0/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xmskm3znbsk7m46g3ds0z79jdmdc7fbj-imv-3.0.0/bin
patching script interpreter paths in /nix/store/xmskm3znbsk7m46g3ds0z79jdmdc7fbj-imv-3.0.0
checking for references to /build in /nix/store/xmskm3znbsk7m46g3ds0z79jdmdc7fbj-imv-3.0.0...
/nix/store/xmskm3znbsk7m46g3ds0z79jdmdc7fbj-imv-3.0.0

@xeji
Copy link
Contributor

xeji commented Sep 3, 2018

According to Hydra history, this never built on darwin or aarch64.
Can you please mark it as broken on these platforms so we can do a little cleanup with the bump?

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Sep 3, 2018

Ok, done.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: imv

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: imv

Partial log (click to expand)

install -D -m 0644 files/imv_config /nix/store/xmskm3znbsk7m46g3ds0z79jdmdc7fbj-imv-3.0.0/etc/imv_config
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xmskm3znbsk7m46g3ds0z79jdmdc7fbj-imv-3.0.0
shrinking /nix/store/xmskm3znbsk7m46g3ds0z79jdmdc7fbj-imv-3.0.0/bin/imv
gzipping man pages under /nix/store/xmskm3znbsk7m46g3ds0z79jdmdc7fbj-imv-3.0.0/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xmskm3znbsk7m46g3ds0z79jdmdc7fbj-imv-3.0.0/bin
patching script interpreter paths in /nix/store/xmskm3znbsk7m46g3ds0z79jdmdc7fbj-imv-3.0.0
checking for references to /build in /nix/store/xmskm3znbsk7m46g3ds0z79jdmdc7fbj-imv-3.0.0...
/nix/store/xmskm3znbsk7m46g3ds0z79jdmdc7fbj-imv-3.0.0

@xeji xeji merged commit 6f91e44 into NixOS:master Sep 3, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: imv

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

aszlig added a commit that referenced this pull request Sep 9, 2018
@aszlig
imv: Include i686-linux in platforms attribute
7bda775 
The package builds and works fine on i686-linux, so there is no need to
fail evaluation on those systems.

Signed-off-by: aszlig <aszlig@nix.build>
Issue: #45976
Cc: @rnhmjoj, @xeji
@rnhmjoj rnhmjoj deleted the imv branch February 23, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @GrahamcOfBorg @xeji