Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appimage-run: Support type-1 Appimages #45973

Merged
merged 1 commit into from Sep 19, 2018
Merged

appimage-run: Support type-1 Appimages #45973

merged 1 commit into from Sep 19, 2018

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented Sep 3, 2018

Motivation for this change

This attempts to detect older appimages and extract them
in the same manner as new ones, without changing filesystem paths

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@tilpner
appimage-run: Support type-1 Appimages
b5eb737 
This attempts to detect older appimages and extract them
in the same manner as new ones, without changing filesystem paths
@tilpner
Copy link
Member Author

tilpner commented Sep 3, 2018

(Prompted by @inquisitiv3 with https://etcher.io/)

This was referenced Sep 19, 2018
Closed
Closed
@xeji
Copy link
Contributor

xeji commented Sep 19, 2018

@GrahamcOfBorg build appimage-run

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: appimage-run

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: appimage-run

Partial log (click to expand)

collision between `/nix/store/a9s3illr7jjjbw70llc9wdnv5i9c2rkz-mesa-noglu-18.1.7/lib/libwayland-egl.so.1.0.0' and `/nix/store/r2hy4ci229mcgzq62hpp0a2pjnjhrhiw-wayland-1.15.0/lib/libwayland-egl.so.1.0.0'
collision between `/nix/store/a9s3illr7jjjbw70llc9wdnv5i9c2rkz-mesa-noglu-18.1.7/lib/libwayland-egl.so.1' and `/nix/store/r2hy4ci229mcgzq62hpp0a2pjnjhrhiw-wayland-1.15.0/lib/libwayland-egl.so.1'
collision between `/nix/store/a9s3illr7jjjbw70llc9wdnv5i9c2rkz-mesa-noglu-18.1.7/lib/libwayland-egl.so' and `/nix/store/r2hy4ci229mcgzq62hpp0a2pjnjhrhiw-wayland-1.15.0/lib/libwayland-egl.so'
collision between `/nix/store/a9s3illr7jjjbw70llc9wdnv5i9c2rkz-mesa-noglu-18.1.7/lib/libwayland-egl.la' and `/nix/store/r2hy4ci229mcgzq62hpp0a2pjnjhrhiw-wayland-1.15.0/lib/libwayland-egl.la'
collision between `/nix/store/1qwavpfqvvbhd290hhg3mxll39addybr-librsvg-2.42.4/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache' and `/nix/store/n3k1rpvzsnrjlh0kdz5k4y9y4kjksr7d-gdk-pixbuf-2.36.12/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache'
created 4865 symlinks in user environment
building '/nix/store/ha79fxhvl3p6isg5y7rn2v40ni4pwhss-appimage-run-fhs.drv'...
building '/nix/store/w8jfz306vij1j0jq64i0vgmn592920bf-appimage-run-init.drv'...
building '/nix/store/ddbvwn7xl380fk79dsjszxc9klcc70sv-appimage-run.drv'...
/nix/store/nfs8af9ff3rp67w2h153v5s2525yag28-appimage-run

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: appimage-run

Partial log (click to expand)

copying path '/nix/store/n0z7lyvxrhcn9yijpyhgr4la18p3ahg7-systemd-239' from 'https://cache.nixos.org'...
copying path '/nix/store/nn1djxjb3naf8difi6vd4l0afp5qam3g-dbus-1.12.10' from 'https://cache.nixos.org'...
copying path '/nix/store/0jn8gmpvz286am95kzzjsayw5qbppmzp-dbus-1.12.10-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/bwb5ykrcjxsh0lybll9z1w12wsa1ww4d-dbus-glib-0.110-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/bpxzx32zfahzhgcmc0f6559wkvh69pla-network-manager-0.9.8.10' from 'https://cache.nixos.org'...
copying path '/nix/store/9289mbnqhp2lvnmknwdgnz46d2npzx97-appimage-run-usr-multi' from 'https://cache.nixos.org'...
copying path '/nix/store/p0y95s0vs108m30krf1r7m6nlykpwq6q-appimage-run-fhs' from 'https://cache.nixos.org'...
building '/nix/store/ijd752l15qij3q519h6vm51hkn3b3bkw-appimage-run-init.drv'...
building '/nix/store/6302j8wjlj7bcy7v4py8s96wjvwxblmw-appimage-run.drv'...
/nix/store/mrixl93vk6dcjdkm0ayj9gywn3sxyq7x-appimage-run

@xeji xeji merged commit 5fb0ed6 into NixOS:master Sep 19, 2018
@tbenst tbenst mentioned this pull request Aug 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tilpner @xeji @GrahamcOfBorg