Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.x509-system: Override based on the host, not target platform for 18.09 #47097

Merged
merged 1 commit into from Sep 21, 2018
Merged

haskellPackages.x509-system: Override based on the host, not target platform for 18.09 #47097

merged 1 commit into from Sep 21, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Backport of #47096.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ericson2314
haskellPackages.x509-system: Override based on the host, not target p…
45c637d 
…latform

There were many reverts back and forth, but it ultimately appears that I
am the source of this mistake. I clarified the comment so as not to
confuse myself or anyone else.
@Ericson2314 Ericson2314 merged commit ef450ef into NixOS:release-18.09 Sep 21, 2018
@Ericson2314 Ericson2314 deleted the fix-x509-system branch September 21, 2018 01:55
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.x509-system

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: haskellPackages.x509-system

Partial log (click to expand)

copying path '/nix/store/x1jx15ai3slxil6myyamwlk2jb5ja9jp-x509-1.7.3-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/apssvxzh1n9wqzlff7q9f1bmbiksn6j0-asn1-types-0.3.2' from 'https://cache.nixos.org'...
copying path '/nix/store/j40h6bskbxjdg7jamyli0ivyflfwc1lr-x509-store-1.6.6-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/iqicidb1p4kwsq0gz8ijf6g9aksbhvfk-x509-system-1.6.6-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/80asis68hwlwj2gqnfwghkadka9b5k53-asn1-encoding-0.9.5' from 'https://cache.nixos.org'...
copying path '/nix/store/d55avb1ykm0dixpmrym6lll91l7yz3ky-asn1-parse-0.9.4' from 'https://cache.nixos.org'...
copying path '/nix/store/li1rqmb8lc0w8zsrmhywyxgh3vga5r3f-x509-1.7.3' from 'https://cache.nixos.org'...
copying path '/nix/store/dn09rjkr2qc5i5m7db75nhkxqr5bgla8-x509-store-1.6.6' from 'https://cache.nixos.org'...
copying path '/nix/store/2hjxvgwv70d9yc4yb0s7f5x4krskya68-x509-system-1.6.6' from 'https://cache.nixos.org'...
/nix/store/2hjxvgwv70d9yc4yb0s7f5x4krskya68-x509-system-1.6.6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: haskellPackages.x509-system

Partial log (click to expand)

copying path '/nix/store/58b6jq7snqsygabn04f172l985d30pjy-asn1-encoding-0.9.5' from 'https://cache.nixos.org'...
copying path '/nix/store/1vjq0alnbm97fa22afyah7fwnwpyavzr-pem-0.2.4' from 'https://cache.nixos.org'...
copying path '/nix/store/k7bvg1r35836bvb4xwxcx0z9b9637i0c-asn1-parse-0.9.4' from 'https://cache.nixos.org'...
copying path '/nix/store/8b2p93rcrlvmvkq8388719qywzvpsnpz-x509-1.7.3-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/sn24lkc69ykgabw3h02ammgif02m1hav-x509-1.7.3' from 'https://cache.nixos.org'...
copying path '/nix/store/9wi5ajx63wsjj7zgh1yggg7c3d3gnfs9-x509-store-1.6.6-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/0ba4krrxhzgg93bg6cwbq9a9crjjlclw-x509-store-1.6.6' from 'https://cache.nixos.org'...
copying path '/nix/store/s3gn0wga9yls0jyqw92cf11565p8qv3n-x509-system-1.6.6-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/nfilhbkq42mp18jfa2y1wxqyh90pf3mg-x509-system-1.6.6' from 'https://cache.nixos.org'...
/nix/store/nfilhbkq42mp18jfa2y1wxqyh90pf3mg-x509-system-1.6.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti peti is a code owner

@ryantm ryantm Awaiting requested review from ryantm ryantm is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @GrahamcOfBorg