Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zathura: disable synctexSupport by default #47033

Closed
wants to merge 1 commit into from
Closed

zathura: disable synctexSupport by default #47033

wants to merge 1 commit into from

Conversation

unode
Copy link
Member

@unode unode commented Sep 20, 2018

If enabled, zathura currently fails to build on 18.09

Motivation for this change

This is currently broken on: https://github.com/NixOS/nixpkgs-channels/tree/nixos-18.09

Failing with:

[29/38] Compiling C object 'zathura@sta/zathura_shortcuts.c.o'.
[30/38] Compiling C object 'zathura@sta/zathura_synctex.c.o'.
FAILED: zathura@sta/zathura_synctex.c.o
/nix/store/iw94llkj05wgaz268mlzvgx8jkbi1ss0-gcc-wrapper-7.3.0/bin/cc -Izathura@sta -I. -I.. -I../ -Idata -I/nix/store/xv568b9mz2vdszss8qm76ck0q05g9ww5-gtk+3-3.22.30-dev/include/gtk-3.0 -I/nix/store/7w6fz25rxw43xihfhyzj2j9c4jlnsdp0-glib-2.56.0-dev/include/glib-2.0 -I/nix/store/wgki8qb0h5q963pm890i0i3kpf15mmd8-glib-2.56.0/lib/glib-2.0/include -I/nix/store/27jaxgs7azws5gpb2w5pddc1qg9nr6m3-cairo-1.15.12-dev/include/cairo -I/nix/store/zavrkx3070qvv5zv8840grl8jrzp3wsk-freetype-2.9-dev/include/freetype2 -I/nix/store/zavrkx3070qvv5zv8840grl8jrzp3wsk-freetype-2.9-dev/include -I/nix/store/qr3k68h122nclxvgfwl9rh25ij36140j-pango-1.42.1-dev/include/pango-1.0 -I/nix/store/w3whis019b8fqsnpgyh3460r84rx4ms7-fribidi-1.0.5/include/fribidi -I/nix/store/ip6incsc37i9lhhyrasl669zi4yy392b-gdk-pixbuf-2.36.12-dev/include/gdk-pixbuf-2.0 -I/nix/store/pkq35lfwa1img2d4jb74nid73g9mbxwl-atk-2.28.1-dev/include/atk-1.0 -I/nix/store/mcf1dlzaglp66rp9ajxal7g4lz8kp38x-girara-0.3.0/include -I/nix/store/7w6fz25rxw43xihfhyzj2j9c4jlnsdp0-glib-2.56.0-dev/include/gio-unix-2.0/ -I/nix/store/1f78125jdwigxk7m72p7rxplvhy30abf-sqlite-3.24.0-dev/include -I/nix/store/lqziwnwams56sil06vddravn6iiaswb6-texlive-bin-2018/include/synctex -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=c11 -O3 -fPIC -pthread '-DGETTEXT_PACKAGE="zathura"' '-DLOCALEDIR="/nix/store/plbnhjkw1la7aihmcdn8l6x34v3g3sha-zathura-core-0.4.0/share/locale"' '-DZATHURA_PLUGINDIR="/nix/store/plbnhjkw1la7aihmcdn8l6x34v3g3sha-zathura-core-0.4.0/lib/zathura"' -D_DEFAULT_SOURCE -DWITH_SQLITE -DWITH_SYNCTEX -DWITH_SYNCTEX1 -DWITH_MAGIC -Wall -Wextra -pedantic -Werror=implicit-function-declaration -Werror=vla -fvisibility=hidden  -MD -MQ 'zathura@sta/zathura_synctex.c.o' -MF 'zathura@sta/zathura_synctex.c.o.d' -o 'zathura@sta/zathura_synctex.c.o' -c ../zathura/synctex.c
In file included from ../zathura/synctex.c:8:0:
/nix/store/lqziwnwams56sil06vddravn6iiaswb6-texlive-bin-2018/include/synctex/synctex_parser.h:53:10: fatal error: synctex_version.h: No such file or directory
 #include "synctex_version.h"
          ^~~~~~~~~~~~~~~~~~~
compilation terminated.
ninja: build stopped: subcommand failed.
builder for '/nix/store/5nnjbn8cdq0mxz9cq34gaz9v697k81xs-zathura-core-0.4.0.drv' failed with exit code 1
cannot build derivation '/nix/store/bz90skc33pp4g5gvxviaqdlx9dryqqxk-zathura-with-plugins-0.4.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/qrxlymp46pnm4rjrhg279xvy02bngn1y-system-path.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/0p4laz83y06a28sm8zzan81xkhgkhpzi-nixos-system-nebula-18.09.git.643f31a.drv': 1 dependencies couldn't be built
error: build of '/nix/store/0p4laz83y06a28sm8zzan81xkhgkhpzi-nixos-system-nebula-18.09.git.643f31a.drv' failed

Disabling it makes zathura build successfully.

I'd also like to request a backport of this change to 18.09 in order to avoid having the package broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@unode
zathura: disable synctexSupport by default
4655ebc 
If enabled, zathura currently fails to build on 18.09
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: zathura

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/i916i1rip1ydigqhwlbf7pv1ghnx0r68-zathura-pdf-mupdf-0.3.3
shrinking /nix/store/i916i1rip1ydigqhwlbf7pv1ghnx0r68-zathura-pdf-mupdf-0.3.3/lib/zathura/libpdf-mupdf.so
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i916i1rip1ydigqhwlbf7pv1ghnx0r68-zathura-pdf-mupdf-0.3.3/lib
patching script interpreter paths in /nix/store/i916i1rip1ydigqhwlbf7pv1ghnx0r68-zathura-pdf-mupdf-0.3.3
checking for references to /build in /nix/store/i916i1rip1ydigqhwlbf7pv1ghnx0r68-zathura-pdf-mupdf-0.3.3...
building '/nix/store/l46arswj6dcb47hjxbgr98m57q5kvfhg-zathura-with-plugins-0.4.0.drv'...
/nix/store/3bg5n8vilfz0490a17sfidapdjl79qfs-zathura-with-plugins-0.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: zathura

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/r29vx4kbpp0xn49y4bf10b2b5kbmrc27-zathura-ps-0.2.6
shrinking /nix/store/r29vx4kbpp0xn49y4bf10b2b5kbmrc27-zathura-ps-0.2.6/lib/zathura/libps.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r29vx4kbpp0xn49y4bf10b2b5kbmrc27-zathura-ps-0.2.6/lib
patching script interpreter paths in /nix/store/r29vx4kbpp0xn49y4bf10b2b5kbmrc27-zathura-ps-0.2.6
checking for references to /build in /nix/store/r29vx4kbpp0xn49y4bf10b2b5kbmrc27-zathura-ps-0.2.6...
building '/nix/store/6vjgxq0pchpps3b8cxzz160r69gh77gb-zathura-with-plugins-0.4.0.drv'...
/nix/store/x5v0wjnld3wjf9s262f719y1dlk5bcl8-zathura-with-plugins-0.4.0

@xeji
Copy link
Contributor

xeji commented Sep 20, 2018

@globin @samueldr have worked on fixing this. Maybe we'll have a solution shortly?

@7c6f434c
Copy link
Member

I think Zathura builds fine on master: https://hydra.nixos.org/job/nixpkgs/trunk/zathura.x86_64-linux

Maybe this PR should be against 18.09 directly?

@xeji
Copy link
Contributor

xeji commented Sep 21, 2018

I think Zathura builds fine on master

Correct, but that's because 18.09 is already on texlive 2018 (which causes Zathura to fail) while master is still on texlive 2017. The 2018 update is in staging-next which has been delayed for weeks (#45941). As soon as staging-next is merged, master will have the same issue.

So no, I think this PR should go to master.

@xeji
Copy link
Contributor

xeji commented Sep 21, 2018

An update to zathura 0.4.1 (released yesterday) fixes the synctex issue (on 18.09, can't test on master yet). Working on a PR right now.

@xeji xeji mentioned this pull request Sep 21, 2018
Merged
9 tasks
@xeji xeji closed this in #47140 Sep 22, 2018
@unode unode deleted the patch-2 branch September 22, 2018 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@unode @GrahamcOfBorg @xeji @7c6f434c