nixos/tests/ferm: disable dhcpcd #47077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test failed in one run on Hydra, logs look like dhcpcd changed ipv6 routing at just the wrong time. Disable dhcpcd. It's not needed, the test uses static IPs anyway.
|
please backport to 18.09 (that's where the failed test run happened). @GrahamcOfBorg test ferm |
|
Success on x86_64-linux (full log) Attempted: tests.ferm Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: tests.ferm Partial log (click to expand)
|
|
backport: 793776b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The test failed in one recent run on Hydra.
The only notable difference in the logs compared to successful runs is that dhcpcd changed ipv6 default routing on the client just when it tried to contact the server via ipv6. I could not reproduce the failure locally and it's hard to tell from the logs whether this really was the cause.
But since this test uses static IP addresses anyway, it doesn't need dhcpcd, so let's disable it and eliminate this potential cause of non-deterministic failure.
cc @Mic92
Things done