Orbital icon customization loop performance issues #310
+34
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #309
By looping through just
FlightGlobals.Bodies
instead of all resources, this loop is quite a bit faster (doubled my framerate with GPP + GEP + OPM). I don't know if important bodies are excluded or if this can be optimized more aggressively without better test data (a config with customized icons, preferably a planet pack). Off the top of my head, a more aggressive optimization would be to identify a smaller set of customized bodies once and then loop through only those bodies OR determine if the icons can be set less frequently (only once, for example).Very open to ideas and discussion. I'm not much of an artist/designer (or great with working with those assets) so I question how realistic an orbital icon test case I can put together without some outside guidance.