Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs-10_x: 10.9.0 -> 10.11.0 #47107

Closed
wants to merge 1 commit into from
Closed

nodejs-10_x: 10.9.0 -> 10.11.0 #47107

wants to merge 1 commit into from

Conversation

jwoudenberg
Copy link
Member

Motivation for this change

Nodejs released a new version on the 10.x branch. This updates us to use that latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@alyssais
Copy link
Member

https://nodejs.org/en/ says that 10.11.0 is the current version 🙊

@stoeffel
Copy link

arg that was quick. too bad, we need 10.10.0 for our application. @alyssais do you prefer we change this PR to 10.11.0 or is it okay to update to 10.10.0 first and than make an other PR to 10.11.0?

@jwoudenberg jwoudenberg changed the title nodejs-10_x: 10.9.0 -> 10.10.0 nodejs-10_x: 10.9.0 -> 10.11.0 Sep 21, 2018
@stoeffel
Copy link

stoeffel commented Sep 21, 2018 •
edited

Jasper already changed it, so nevermind. We're going to download the binaries in our nix config directly.

@alyssais
Copy link
Member

@alyssais do you prefer we change this PR to 10.11.0 or is it okay to update to 10.10.0 first and than make an other PR to 10.11.0?

I'm not a maintainer, was just browsing the pull requests and thought I could make a helpful comment :)

@lo1tuma
Copy link
Member

lo1tuma commented Sep 21, 2018 •
edited

The changelog of nodejs 10.11 10.10 says it depends on libuv 1.23 which hasn’t landed yet in nixpkgs master but is already in staging. Should we wait until libuv 1.23 lands in master?

@gilligan
Copy link
Contributor

@lo1tuma yeah i guess we should definitely build it against the right version of libuv at least.

@lo1tuma
Copy link
Member

lo1tuma commented Sep 21, 2018

I’ve just build this locally on darwin, the compilation fails, I guess due to the wrong libuv version:

error: use of undeclared identifier 'uv_os_setpriority'

@jwoudenberg
Copy link
Member Author

Thanks for all comments! Will close this PR while waiting for libuv to land!

@lo1tuma
Copy link
Member

lo1tuma commented Sep 25, 2018

libuv 1.23 is now in master so I think this PR could be rebased & reopened.

@jwoudenberg jwoudenberg mentioned this pull request Sep 25, 2018
Merged
9 tasks
@jwoudenberg
Copy link
Member Author

jwoudenberg commented Sep 25, 2018 •
edited

Github won't allow me to reopen because I rebased on master, so I created this new PR: #47352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jwoudenberg @alyssais @stoeffel @lo1tuma @gilligan @GrahamcOfBorg @Janik-Haag