Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.circus: fix build, add meta #47066

Merged
merged 1 commit into from Sep 20, 2018
Merged

pythonPackages.circus: fix build, add meta #47066

merged 1 commit into from Sep 20, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 20, 2018

Motivation for this change

ZHF #45960. Build failed due to version restrictions, relax them. Also add missing meta.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji xeji requested a review from FRidh as a code owner September 20, 2018 21:41
@xeji
Copy link
Contributor Author

xeji commented Sep 20, 2018

@GrahamcOfBorg build python27Packages.circus python36Packages.circus

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.circus, python36Packages.circus

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/dp63zpn70k4wm06dicxvw51d6vxvzkq3-python3.6-circus-0.15.0
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dp63zpn70k4wm06dicxvw51d6vxvzkq3-python3.6-circus-0.15.0/lib  /nix/store/dp63zpn70k4wm06dicxvw51d6vxvzkq3-python3.6-circus-0.15.0/bin
patching script interpreter paths in /nix/store/dp63zpn70k4wm06dicxvw51d6vxvzkq3-python3.6-circus-0.15.0
checking for references to /build in /nix/store/dp63zpn70k4wm06dicxvw51d6vxvzkq3-python3.6-circus-0.15.0...
wrapping `/nix/store/dp63zpn70k4wm06dicxvw51d6vxvzkq3-python3.6-circus-0.15.0/bin/circusd'...
wrapping `/nix/store/dp63zpn70k4wm06dicxvw51d6vxvzkq3-python3.6-circus-0.15.0/bin/circus-plugin'...
wrapping `/nix/store/dp63zpn70k4wm06dicxvw51d6vxvzkq3-python3.6-circus-0.15.0/bin/circusd-stats'...
wrapping `/nix/store/dp63zpn70k4wm06dicxvw51d6vxvzkq3-python3.6-circus-0.15.0/bin/circusctl'...
wrapping `/nix/store/dp63zpn70k4wm06dicxvw51d6vxvzkq3-python3.6-circus-0.15.0/bin/circus-top'...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.circus, python36Packages.circus

Partial log (click to expand)

wrapping `/nix/store/af7d2a0ryrhkb6ay4b493npwfj69j5j1-python2.7-circus-0.15.0/bin/circusd'...
wrapping `/nix/store/af7d2a0ryrhkb6ay4b493npwfj69j5j1-python2.7-circus-0.15.0/bin/circusctl'...
wrapping `/nix/store/7h3b1d349gsw5rjyxpnzdif2awbz38l1-python3.6-circus-0.15.0/bin/circusd'...
wrapping `/nix/store/af7d2a0ryrhkb6ay4b493npwfj69j5j1-python2.7-circus-0.15.0/bin/circus-plugin'...
wrapping `/nix/store/7h3b1d349gsw5rjyxpnzdif2awbz38l1-python3.6-circus-0.15.0/bin/circusctl'...
wrapping `/nix/store/af7d2a0ryrhkb6ay4b493npwfj69j5j1-python2.7-circus-0.15.0/bin/circusd-stats'...
wrapping `/nix/store/7h3b1d349gsw5rjyxpnzdif2awbz38l1-python3.6-circus-0.15.0/bin/circus-plugin'...
wrapping `/nix/store/af7d2a0ryrhkb6ay4b493npwfj69j5j1-python2.7-circus-0.15.0/bin/circus-top'...
wrapping `/nix/store/7h3b1d349gsw5rjyxpnzdif2awbz38l1-python3.6-circus-0.15.0/bin/circusd-stats'...
wrapping `/nix/store/7h3b1d349gsw5rjyxpnzdif2awbz38l1-python3.6-circus-0.15.0/bin/circus-top'...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.circus, python36Packages.circus

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/1nyfsjr2da276a0f8dzqwpwlhm2k8c18-python3.6-circus-0.15.0/lib  /nix/store/1nyfsjr2da276a0f8dzqwpwlhm2k8c18-python3.6-circus-0.15.0/bin
patching script interpreter paths in /nix/store/1nyfsjr2da276a0f8dzqwpwlhm2k8c18-python3.6-circus-0.15.0
checking for references to /build in /nix/store/1nyfsjr2da276a0f8dzqwpwlhm2k8c18-python3.6-circus-0.15.0...
wrapping `/nix/store/1nyfsjr2da276a0f8dzqwpwlhm2k8c18-python3.6-circus-0.15.0/bin/circus-plugin'...
wrapping `/nix/store/1nyfsjr2da276a0f8dzqwpwlhm2k8c18-python3.6-circus-0.15.0/bin/circus-top'...
wrapping `/nix/store/1nyfsjr2da276a0f8dzqwpwlhm2k8c18-python3.6-circus-0.15.0/bin/circusctl'...
wrapping `/nix/store/1nyfsjr2da276a0f8dzqwpwlhm2k8c18-python3.6-circus-0.15.0/bin/circusd-stats'...
wrapping `/nix/store/1nyfsjr2da276a0f8dzqwpwlhm2k8c18-python3.6-circus-0.15.0/bin/circusd'...
/nix/store/kffmgr9bvawz509f7x1dphxy42adv876-python2.7-circus-0.15.0
/nix/store/1nyfsjr2da276a0f8dzqwpwlhm2k8c18-python3.6-circus-0.15.0

@xeji xeji merged commit 9c02914 into NixOS:master Sep 20, 2018
@xeji xeji deleted the p/circus branch September 20, 2018 22:19
xeji added a commit that referenced this pull request Sep 20, 2018
@xeji
pythonPackages.circus: fix build, add meta (#47066)
abdbf1c 
(cherry picked from commit 9c02914)
@xeji
Copy link
Contributor Author

xeji commented Sep 20, 2018

backported: abdbf1c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xeji @GrahamcOfBorg