Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utmps: init at 0.0.1.3 #47100

Merged
merged 2 commits into from Sep 21, 2018
Merged

utmps: init at 0.0.1.3 #47100

merged 2 commits into from Sep 21, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 21, 2018

Haven't tried using it, but packging it is first step! :)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
utmps: init at 0.0.1.3
e869320 
Haven't tried using it, but packging it is first step! :)
@Profpatsch
Copy link
Member

Profpatsch commented Sep 21, 2018 •
edited

Nice!
I’m sure I can get rid of the configure flag boilerplate sometime. It’s the same for every skaware package.

@GrahamcOfBorg build skawarePackages.utmps

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: skawarePackages

The following builds were skipped because they don't evaluate on x86_64-linux: utmps

Partial log (click to expand)

/nix/store/w7p0f2mbzf648zbf8z0njmdgigpblhgr-execline-2.5.0.1-bin
/nix/store/1x271azwygwg0p2c2scjqgi3rd92qnja-nsss-0.0.1.0-bin
/nix/store/4gczxy1v63ypm26sifg4y44ypzj8mfa2-s6-2.7.2.0
/nix/store/mq4hm5al1db4jbi9cf3dzk0fdnmvsv9g-s6-dns-2.3.0.1-bin
/nix/store/hjqjhmvfpdjg4qapii0m2wj5kam0faqz-s6-linux-utils-2.5.0.0-bin
/nix/store/cr4nlv80dk4hlmac3il01vg3y8pihy6l-s6-networking-2.3.0.3-bin
/nix/store/f9bgi4s3bd4nxd83gvkib2zmxj0wn1x4-s6-portable-utils-2.2.1.2-bin
/nix/store/gz37bi4adq0x3gm1yxlr6gq5i79ny4vz-s6-rc-0.4.1.0-bin
/nix/store/v700gh0xrizvk0r4pxfqnlx69css802b-skalibs-2.7.0.0-lib
/nix/store/hc0qw5nkr7drjv0nzlkg1c3zva4six5x-utmps-0.0.1.3-bin

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: skawarePackages, utmps

Partial log (click to expand)

in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


Cannot nix-instantiate `utmps' because:
error: attribute 'utmps' in selection path 'utmps' not found

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: skawarePackages.utmps

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/91ps0sn1jw92al03n1fvxb4an9qi6h74-utmps-0.0.1.3-doc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/91ps0sn1jw92al03n1fvxb4an9qi6h74-utmps-0.0.1.3-doc
checking for references to /build in /nix/store/91ps0sn1jw92al03n1fvxb4an9qi6h74-utmps-0.0.1.3-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/sarh62w307k8r406vszi8kgp40vg2jfi-utmps-0.0.1.3
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/sarh62w307k8r406vszi8kgp40vg2jfi-utmps-0.0.1.3
checking for references to /build in /nix/store/sarh62w307k8r406vszi8kgp40vg2jfi-utmps-0.0.1.3...
Checking for remaining source files
/nix/store/hc0qw5nkr7drjv0nzlkg1c3zva4six5x-utmps-0.0.1.3-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: skawarePackages

The following builds were skipped because they don't evaluate on aarch64-linux: utmps

Partial log (click to expand)

/nix/store/2f662r9x1412xp4z2qbgab7wxxr7z2sp-execline-2.5.0.1-bin
/nix/store/wfwr9xs6hyibphj0g4rbpx6ckz92lvz9-nsss-0.0.1.0-bin
/nix/store/wyykiq3hy1mw30fggvbps5m85q5b2yjh-s6-2.7.2.0
/nix/store/dp4lhsnb45z5738c571kv62xx9div796-s6-dns-2.3.0.1-bin
/nix/store/cykyfjnwwi491az0pc0k61wl2jblaffr-s6-linux-utils-2.5.0.0-bin
/nix/store/d35riv5igywmmmyjqcbirqmm12fw139f-s6-networking-2.3.0.3-bin
/nix/store/bhyhc9l6dywcrwnckqp47mlac4zm5na8-s6-portable-utils-2.2.1.2-bin
/nix/store/la76mqafcnvz06nwk7plpqbkaqf5y4l9-s6-rc-0.4.1.0-bin
/nix/store/zwcj4x3ang9609qk5v8p941pama6x5wa-skalibs-2.7.0.0-lib
/nix/store/y9vcp43dvfd8y7m6x6x8ai2wfknnrpvk-utmps-0.0.1.3-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: skawarePackages.utmps

Partial log (click to expand)

/nix/store/y9vcp43dvfd8y7m6x6x8ai2wfknnrpvk-utmps-0.0.1.3-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: skawarePackages.utmps

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/zvjfld1hf2w2yf71l4mzpmkww1qqx3rk-utmps-0.0.1.3-lib/lib
patching script interpreter paths in /nix/store/zvjfld1hf2w2yf71l4mzpmkww1qqx3rk-utmps-0.0.1.3-lib
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/fabd22a11bdrs74vhkwlf2mfxzihvgja-utmps-0.0.1.3-dev
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/hrlk8dsa2p3qnwhq90k35z89zfacc1fy-utmps-0.0.1.3-doc
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/rhhpzq5d7qj80m0nbn07f29vwkrvxzwm-utmps-0.0.1.3
Checking for remaining source files
/nix/store/srm3fs4xv4n1wj8ispny8pz7ycifybmw-utmps-0.0.1.3-bin

Profpatsch
Profpatsch requested changes Sep 21, 2018
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -12075,6 +12075,7 @@ with pkgs;
s6-rc = callPackage ../tools/system/s6-rc { };

nsss = callPackage ../development/libraries/nsss { };
utmps = callPackage ../development/libraries/utmps { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added all of these to the toplevel, e.g nsss = skawarePackages.nsss;.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: utmps

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/zvjfld1hf2w2yf71l4mzpmkww1qqx3rk-utmps-0.0.1.3-lib/lib
patching script interpreter paths in /nix/store/zvjfld1hf2w2yf71l4mzpmkww1qqx3rk-utmps-0.0.1.3-lib
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/fabd22a11bdrs74vhkwlf2mfxzihvgja-utmps-0.0.1.3-dev
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/hrlk8dsa2p3qnwhq90k35z89zfacc1fy-utmps-0.0.1.3-doc
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/rhhpzq5d7qj80m0nbn07f29vwkrvxzwm-utmps-0.0.1.3
Checking for remaining source files
/nix/store/srm3fs4xv4n1wj8ispny8pz7ycifybmw-utmps-0.0.1.3-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: utmps

Partial log (click to expand)

/nix/store/y9vcp43dvfd8y7m6x6x8ai2wfknnrpvk-utmps-0.0.1.3-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: utmps

Partial log (click to expand)

/nix/store/hc0qw5nkr7drjv0nzlkg1c3zva4six5x-utmps-0.0.1.3-bin

@Profpatsch
Copy link
Member

Awesome.

@Profpatsch Profpatsch closed this Sep 21, 2018
@Profpatsch Profpatsch reopened this Sep 21, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: utmps

Partial log (click to expand)

/nix/store/srm3fs4xv4n1wj8ispny8pz7ycifybmw-utmps-0.0.1.3-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: utmps

Partial log (click to expand)

/nix/store/y9vcp43dvfd8y7m6x6x8ai2wfknnrpvk-utmps-0.0.1.3-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: utmps

Partial log (click to expand)

/nix/store/hc0qw5nkr7drjv0nzlkg1c3zva4six5x-utmps-0.0.1.3-bin

@dtzWill dtzWill merged commit 9908e9c into NixOS:master Sep 21, 2018
@dtzWill dtzWill deleted the feature/utmps branch September 21, 2018 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Profpatsch approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @Profpatsch @GrahamcOfBorg