Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NewCrewStations.cfg (port be7a24b) (#783) #901

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

Tidal-Stream
Copy link
Contributor

#783, merged in commit be7a24b, fixes the empty seat requirement in the contract. It was merged only in master and not in Developmental. This ports it to Developmental.

As I read this, the point of this contract is to send crew to an empty station.  But the current requirement is set to only allow the contract to occur when there are less than 3 vacant seats available.  Meaning if a station can support 5 crew and you have 3 on the station, the contract would become available because "EmptyCrewSpace()" would return a result of 2.  By using "v.CrewCount()==0" we should only allow the contract to occur when a station has no crew on board, regardless of how many available seats there may be.
Copy link
Contributor

@Bornholio Bornholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as change intends, though i suspect the contract is trying to get a ISS rotation instead. doesn't work right currently

@ec429
Copy link
Contributor

ec429 commented Oct 15, 2018

@Bornholio there's a separate contract for rotating out an existing crew (Crew Rotation Station.cfg), AFAICT that one works fine.

@ec429 ec429 merged commit 36476ae into KSP-RO:Developmental Oct 15, 2018
@Tidal-Stream Tidal-Stream deleted the newcrewstations branch October 15, 2018 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants