gitAndTools.pass-git-helper: init at 0.4 #47056
Conversation
| { stdenv, buildPythonPackage, isPy3k, fetchFromGitHub, pyxdg }: | ||
|
|
||
| buildPythonPackage rec { | ||
| pname = "git-pass-helper"; |
There was a problem hiding this comment.
We put most git related packages into pkgs/applications/version-management/git-and-tools. Would this one fit there too?
vanzef
force-pushed
the
pass-git-helper
branch
from
6f0c5ec
to
732b273
Compare
| @@ -0,0 +1,24 @@ | |||
| { stdenv, buildPythonPackage, isPy3k, fetchFromGitHub, pyxdg }: | |||
|
|
|||
| buildPythonPackage rec { | |||
There was a problem hiding this comment.
okay. Now we have to decide if it is a python package that you want to use a dependency or an application where we use the executable from. This seems to be the latter one. In this case use buildPythonApplication and reference it in pkgs/applications/version-management/git-and-tools/default.nix. It will be then exposed as gitAndTools.pass-git-helper.
There was a problem hiding this comment.
Should I delete the reference from /pkgs/top-level/python-packages.nix then?
| { stdenv, buildPythonPackage, isPy3k, fetchFromGitHub, pyxdg }: | ||
|
|
||
| buildPythonPackage rec { | ||
| pname = "git-pass-helper"; |
There was a problem hiding this comment.
pass-git-helper instead of git-pass-helper?
There was a problem hiding this comment.
Sure, you are right.
vanzef
force-pushed
the
pass-git-helper
branch
from
732b273
to
45dc266
Compare
vanzef
force-pushed
the
pass-git-helper
branch
from
45dc266
to
3c08fd0
Compare
Mic92
changed the title
Motivation for this change
Adding pass integration for git credentials.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)