Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dune: 1.1.1 -> 1.2.1 #47074

Closed
wants to merge 2 commits into from
Closed

dune: 1.1.1 -> 1.2.1 #47074

wants to merge 2 commits into from

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Sep 20, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @vbgl

@vbgl
Copy link
Contributor

vbgl commented Sep 21, 2018

@GrahamcOfBorg build pyre

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pyre

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: pyre

Partial log (click to expand)

make[1]: Leaving directory '/build/source/hack_parallel'
dune build @install -j auto --profile release
File "dune", line 2, characters 13-41:
2 | (copy_files# external/taint/test/*.ml{,i})
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: cannot find directory: external/taint/test
make: *** [Makefile:32: release] Error 1
builder for '/nix/store/82yag87ycyhbr97gb4mzny10d4mqxjnl-pyre-0.0.11.drv' failed with exit code 2
cannot build derivation '/nix/store/xh48y0cpp06dqw6b3vf6hsvqw73xr2dm-pyre-check-0.0.11.drv': 1 dependencies couldn't be built
error: build of '/nix/store/xh48y0cpp06dqw6b3vf6hsvqw73xr2dm-pyre-check-0.0.11.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: pyre

Partial log (click to expand)

-> stderr:
Fatal error: exception (runtime-lib/runtime.ml.E "comparison failed"
  ((switch true) vs (switch false) (Loc src/config/discover.ml:205:15)))
Raised at file "src/configurator.ml", line 511, characters 13-22
Called from file "src/config/discover.ml", line 136, characters 2-1023
make: *** [Makefile:5: default] Error 1
builder for '/nix/store/6dh8xxpdcx9n0h5jhn1nhvhwbyv0pgyg-ocaml4.06.1-core-0.11.2.drv' failed with exit code 2
cannot build derivation '/nix/store/qi7irnp5dq96av6j8q9j2qab5wdxlbdd-pyre-0.0.11.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/yf52q748f17ch10yn9794lrgdjhgpl6n-pyre-check-0.0.11.drv': 1 dependencies couldn't be built
error: build of '/nix/store/yf52q748f17ch10yn9794lrgdjhgpl6n-pyre-check-0.0.11.drv' failed

@vbgl
Copy link
Contributor

vbgl commented Sep 21, 2018

Please address the regression on linux: this breaks pyre. Updating it to a more recent version (say 0.0.14) should help.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Sep 21, 2018

Sure, sorry I was kind of lazy and should have run nox-review before submitting the PR.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Sep 21, 2018

@vbgl Done. I still haven't run nox-review though. Let me know if I should do it.

@vbgl
Copy link
Contributor

vbgl commented Sep 21, 2018

Updating pyre sure deserves its own commit. And probably its own PR. Thanks.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Sep 21, 2018

Alright.

@Zimmi48 Zimmi48 mentioned this pull request Sep 21, 2018
9 tasks
@Zimmi48
Copy link
Member Author

Zimmi48 commented Sep 21, 2018

Should I rebase now that the other PR is merged?

@vbgl
Copy link
Contributor

vbgl commented Sep 22, 2018

Merged in d1b97bc.

@vbgl vbgl closed this Sep 22, 2018
@Zimmi48 Zimmi48 deleted the dune-1.2.1 branch September 22, 2018 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants