Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tamarin-prover: fix ghc 8.4 build #46597

Merged
merged 1 commit into from Sep 13, 2018
Merged

tamarin-prover: fix ghc 8.4 build #46597

merged 1 commit into from Sep 13, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 13, 2018 •
edited

Motivation for this change

See https://hydra.nixos.org/build/81125645

`tamarin-prover' upstream has a patch to fix GHC 8.4 compilation (and
uses stack lts-12.1 now), but it's not released yet:

tamarin-prover/tamarin-prover@a08f6e4

The build is divided in several derivations, therefore the patch had to
be splitted and rebased for lib/term', lib/theory' and lib/utils' to ensure that the patch applies properly during the patchPhase'.

Addresses #45960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27
tamarin-prover: fix ghc 8.4 build
80863ba 
See https://hydra.nixos.org/build/81125645

`tamarin-prover' upstream has a patch to fix GHC 8.4 compilation (and
uses stack lts-12.1 now), but it's not released yet:

tamarin-prover/tamarin-prover@a08f6e4

The build is divided in several derivations, therefore the patch had to
be splitted and rebased for `lib/term', `lib/theory' and `lib/utils' to
ensure that the patch applies properly during the `patchPhase'.

Addresses NixOS#45960
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tamarin-prover

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tamarin-prover

Partial log (click to expand)

/nix/store/70r4arv1zmy3n5n6jw6aky4r0clgfx9k-tamarin-prover-1.4.0/bin is not in
the system search path.
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/70r4arv1zmy3n5n6jw6aky4r0clgfx9k-tamarin-prover-1.4.0
shrinking /nix/store/70r4arv1zmy3n5n6jw6aky4r0clgfx9k-tamarin-prover-1.4.0/bin/.tamarin-prover-wrapped
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/70r4arv1zmy3n5n6jw6aky4r0clgfx9k-tamarin-prover-1.4.0/bin
patching script interpreter paths in /nix/store/70r4arv1zmy3n5n6jw6aky4r0clgfx9k-tamarin-prover-1.4.0
checking for references to /build in /nix/store/70r4arv1zmy3n5n6jw6aky4r0clgfx9k-tamarin-prover-1.4.0...
/nix/store/70r4arv1zmy3n5n6jw6aky4r0clgfx9k-tamarin-prover-1.4.0

@xeji
Copy link
Contributor

xeji commented Sep 13, 2018

Let's check darwin just to make sure
@GrahamcOfBorg build tamarin-prover

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tamarin-prover

Partial log (click to expand)

/nix/store/70r4arv1zmy3n5n6jw6aky4r0clgfx9k-tamarin-prover-1.4.0

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tamarin-prover

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: tamarin-prover

Partial log (click to expand)

installing
Installing executable tamarin-prover in /nix/store/yzz7fvzz3vdn4sbgyhnadbi8lm88v5v8-tamarin-prover-1.4.0/bin
Warning: The directory
/nix/store/yzz7fvzz3vdn4sbgyhnadbi8lm88v5v8-tamarin-prover-1.4.0/bin is not in
the system search path.
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/yzz7fvzz3vdn4sbgyhnadbi8lm88v5v8-tamarin-prover-1.4.0/lib  /nix/store/yzz7fvzz3vdn4sbgyhnadbi8lm88v5v8-tamarin-prover-1.4.0/bin
patching script interpreter paths in /nix/store/yzz7fvzz3vdn4sbgyhnadbi8lm88v5v8-tamarin-prover-1.4.0
/nix/store/yzz7fvzz3vdn4sbgyhnadbi8lm88v5v8-tamarin-prover-1.4.0

@xeji xeji merged commit 2cfc0bb into NixOS:master Sep 13, 2018
@Ma27 Ma27 deleted the fix-tamarin-prover branch September 13, 2018 12:12
xeji pushed a commit that referenced this pull request Sep 13, 2018
@Ma27 @xeji
tamarin-prover: fix ghc 8.4 build (#46597)
3625ce7 
See https://hydra.nixos.org/build/81125645

`tamarin-prover' upstream has a patch to fix GHC 8.4 compilation (and
uses stack lts-12.1 now), but it's not released yet:

tamarin-prover/tamarin-prover@a08f6e4

The build is divided in several derivations, therefore the patch had to
be splitted and rebased for `lib/term', `lib/theory' and `lib/utils' to
ensure that the patch applies properly during the `patchPhase'.

Addresses #45960

(cherry picked from commit 2cfc0bb)
@xeji
Copy link
Contributor

xeji commented Sep 13, 2018

backported: 3625ce7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @GrahamcOfBorg @xeji