18.09: kubernetes: 1.10.5 -> 1.11.3 #46598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed minor issue where kube-addon manager complaints about /opt/namespace.yaml missing. Added release notes with reference to Kubernetes 1.11 release notes. closes NixOS#43882 (cherry picked from commit a49f56c)
srhb
changed the title
|
Success on x86_64-darwin (full log) Attempted: kubernetes Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: kubernetes Partial log (click to expand)
|
|
@GrahamcOfBorg test kubernetes.rbac.singlenode kubernetes.dns.singlenode kubernetes.rbac.multinode kubernetes.dns.multinode |
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: tests.kubernetes.rbac.singlenode, tests.kubernetes.dns.singlenode, tests.kubernetes.rbac.multinode, tests.kubernetes.dns.multinode Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: kubernetes Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: tests.kubernetes.rbac.singlenode, tests.kubernetes.dns.singlenode, tests.kubernetes.rbac.multinode, tests.kubernetes.dns.multinode Partial log (click to expand)
|
|
Right on, I'm going on the assumption that 1.10 → 1.11 is right, as long as it's compatible (which you said it is). I'm assuming the 1.10 series may not receive updates, though I don't know what's the support cycle of kubernetes. Though it looks like they support the three latest versions. So it's not critical, but a fine addition to update to 1.11. Additionally they say they are generally compatible with some skew in the versions. And last, the first 1.11 release is from before the 18.09 branch-off, so it's double-plus-good to integrate it, as users would probably expect "latest stable version at the moment the OS version branched off". 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #46573 to 18.09. The module revamp did not make the cut for this release. See the comments on that PR for compatibility, namely that 1.11 works with our current modules (with the same issues that 1.10 has) and keeps us up to date.
@samueldr I assume this is still an acceptable backport, as long as we don't touch the module, right?
(cherry picked from commit a49f56c)
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)