Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.BTrees: fix build #46588

Merged
merged 1 commit into from Sep 13, 2018
Merged

pythonPackages.BTrees: fix build #46588

merged 1 commit into from Sep 13, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 12, 2018

Motivation for this change

ZHF #45960.
A test case failed since the update to 4.5.1, disable it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
pythonPackages.BTrees: fix build
90c291c 
a test case failed since the update to 4.5.1, disable it
@xeji xeji requested a review from FRidh as a code owner September 12, 2018 23:32
@xeji
Copy link
Contributor Author

xeji commented Sep 12, 2018

@GrahamcOfBorg build python27Packages.BTrees python36Packages.BTrees

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.BTrees, python36Packages.BTrees

Partial log (click to expand)

testBothNone (BTrees.tests.test_OIBTree.TestWeightedOIPy) ... ok
testIntersection (BTrees.tests.test_OIBTree.TestWeightedOIPy) ... ok
testLeftNone (BTrees.tests.test_OIBTree.TestWeightedOIPy) ... ok
testRightNone (BTrees.tests.test_OIBTree.TestWeightedOIPy) ... ok
testUnion (BTrees.tests.test_OIBTree.TestWeightedOIPy) ... ok

----------------------------------------------------------------------
Ran 4257 tests in 51.088s

OK (skipped=247)

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.BTrees, python36Packages.BTrees

Partial log (click to expand)

test_itervalues_filled_no_args (BTrees.tests.test__base.TreeTests) ... ok
test_itervalues_filled_w_args (BTrees.tests.test__base.TreeTests) ... ok
test_values_empty_no_args (BTrees.tests.test__base.TreeTests) ... ok
test_values_filled_no_args (BTrees.tests.test__base.TreeTests) ... ok
test_values_filled_w_args (BTrees.tests.test__base.TreeTests) ... ok

----------------------------------------------------------------------
Ran 4257 tests in 43.112s

OK (skipped=247)

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.BTrees, python36Packages.BTrees

Partial log (click to expand)

test32 (BTrees.tests.testBTrees.FamilyTest) ... ok
test64 (BTrees.tests.testBTrees.FamilyTest) ... ok
testFoo (BTrees.tests.testBTrees.TestCmpError) ... ok

----------------------------------------------------------------------
Ran 4257 tests in 258.726s

OK (skipped=247)
/nix/store/p1g77rlz39nag3mmqdr8mvhcbqsjgzjd-python2.7-BTrees-4.5.1
/nix/store/9rf0xr4c2x9fj3wy0y9hbhkfbgjjd9n6-python3.6-BTrees-4.5.1

@xeji
Copy link
Contributor Author

xeji commented Sep 12, 2018

@GrahamcOfBorg build vulnix

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: vulnix

Partial log (click to expand)


----------------------------------------------------------------------
Ran 1164 tests in 110.859s

FAILED (failures=3)
Test failed: <unittest.runner.TextTestResult run=1164 errors=0 failures=3>
error: Test failed: <unittest.runner.TextTestResult run=1164 errors=0 failures=3>
builder for '/nix/store/kgainmgnw2jj0wmwlpzvy0chnvdqk6rq-python3.6-ZODB-5.4.0.drv' failed with exit code 1
cannot build derivation '/nix/store/jz65z70rvaixqa0ijsj1555r6ss63l66-vulnix-1.7.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/jz65z70rvaixqa0ijsj1555r6ss63l66-vulnix-1.7.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: vulnix

Partial log (click to expand)

----------------------------------------------------------------------
Ran 1164 tests in 104.762s

FAILED (failures=3)
Test failed: <unittest.runner.TextTestResult run=1164 errors=0 failures=3>
error: Test failed: <unittest.runner.TextTestResult run=1164 errors=0 failures=3>
builder for '/nix/store/1xcp0wwcsjylb3h06f043asgl0528bgc-python3.6-ZODB-5.4.0.drv' failed with exit code 1
copying path '/nix/store/psi62i0ib6kn3x4gbhdw44h3jb4a1rpz-ronn-0.7.3' from 'https://cache.nixos.org'...
cannot build derivation '/nix/store/6iiikaly0yha7fsvsls3853cdp85yr9v-vulnix-1.7.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/6iiikaly0yha7fsvsls3853cdp85yr9v-vulnix-1.7.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: vulnix

Partial log (click to expand)


----------------------------------------------------------------------
Ran 1164 tests in 106.344s

FAILED (failures=3)
Test failed: <unittest.runner.TextTestResult run=1164 errors=0 failures=3>
error: Test failed: <unittest.runner.TextTestResult run=1164 errors=0 failures=3>
builder for '/nix/store/w90zq9arqkfsf3yvaxs0h9p1qi9s2a48-python3.6-ZODB-5.4.0.drv' failed with exit code 1
cannot build derivation '/nix/store/sa2bg1g7vjcdnzdjsa878iv2hkb6sf45-vulnix-1.7.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/sa2bg1g7vjcdnzdjsa878iv2hkb6sf45-vulnix-1.7.1.drv' failed

@xeji
Copy link
Contributor Author

xeji commented Sep 12, 2018 •
edited

So ZODB needs to be fixed as well for vulnix, but that's unrelated to this PR.

@xeji xeji merged commit 68b7de9 into NixOS:master Sep 13, 2018
@xeji xeji deleted the p/btrees branch September 13, 2018 00:32
xeji added a commit that referenced this pull request Sep 13, 2018
@xeji
pythonPackages.BTrees: fix build (#46588)
3e31aa3 
a test case failed since the update to 4.5.1, disable it

(cherry picked from commit 68b7de9)
@xeji
Copy link
Contributor Author

xeji commented Sep 13, 2018

backported: 3e31aa3

@xeji xeji mentioned this pull request Sep 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xeji @GrahamcOfBorg