treewide: fix config.allowAliases = false evaluation
#46593
Conversation
pkgs/top-level/all-packages.nix
Outdated
| @@ -18201,7 +18201,9 @@ with pkgs; | |||
|
|
|||
| qbittorrent = libsForQt5.callPackage ../applications/networking/p2p/qbittorrent { }; | |||
|
|
|||
| qcomicbook = libsForQt5.callPackage ../applications/graphics/qcomicbook { }; | |||
| qcomicbook = libsForQt5.callPackage ../applications/graphics/qcomicbook { | |||
| poppler = libsForQt5.poppler; | |||
There was a problem hiding this comment.
This does not have any effect and can be removed. Because of qcomicbook = libsForQt5.callPackage ..., poppler is already the qt5 variant.
| @@ -309,7 +309,7 @@ self = generated // (with generated; { | |||
| ''; | |||
| }); | |||
|
|
|||
| yankring = yankring.overrideAttrs(old: { | |||
| YankRing-vim = YankRing-vim.overrideAttrs(old: { | |||
There was a problem hiding this comment.
Do you have an idea how to rewrite this so it would fail to evaluate also when allowAliases has its default value? Otherwise we will see this also in future.
There was a problem hiding this comment.
Yes, we can do something like is done with top-level/aliases.nix. I will look into this, since I want to use this configuration option with r-ryantm/nixpkgs-update and it would be nice to not have to fix it all the time.
There was a problem hiding this comment.
@Mic92 Another option would be to make a vim-specific alias configuration: config.allowVimPluginAliases then vim plugin people can break their own evaluation whenever they want.
Motivation for this change
Our configuration options should evaluate!
Things done
tested evaluation with
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)