Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mako: init at 1.1 #46606

Merged
merged 1 commit into from Oct 23, 2018
Merged

mako: init at 1.1 #46606

merged 1 commit into from Oct 23, 2018

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Sep 13, 2018

mako currently works on Sway 1.0 alpha.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: mako

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: mako

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

xeji
xeji suggested changes Sep 13, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add a new package in a broken state. Should not be merged until non-broken.

@dywedir
Copy link
Member Author

dywedir commented Sep 13, 2018 •
edited

Just a note that mako is not broken per se, but useless without a compositor that supports zwlr_layer_shell_v1 protocol

@xeji
Copy link
Contributor

xeji commented Sep 13, 2018

Thank you for clarifying. I suggest to leave this PR open and mark it as WIP until that compositor is available. Unfortunately there seems to be no published timeline for the sway 1.0 release.

@dywedir dywedir changed the title mako: init at 1.1 [WIP] mako: init at 1.1 Sep 13, 2018
@dywedir dywedir changed the title [WIP] mako: init at 1.1 mako: init at 1.1 Oct 23, 2018
@dywedir
Copy link
Member Author

dywedir commented Oct 23, 2018

@GrahamcOfBorg build mako

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mako

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9hvcyv9gm3cg41y40b6cs9vbgxfni9md-mako-1.1
shrinking /nix/store/9hvcyv9gm3cg41y40b6cs9vbgxfni9md-mako-1.1/bin/mako
gzipping man pages under /nix/store/9hvcyv9gm3cg41y40b6cs9vbgxfni9md-mako-1.1/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9hvcyv9gm3cg41y40b6cs9vbgxfni9md-mako-1.1/bin
patching script interpreter paths in /nix/store/9hvcyv9gm3cg41y40b6cs9vbgxfni9md-mako-1.1
/nix/store/9hvcyv9gm3cg41y40b6cs9vbgxfni9md-mako-1.1/bin/makoctl: interpreter directive changed from "/bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/9hvcyv9gm3cg41y40b6cs9vbgxfni9md-mako-1.1...
/nix/store/9hvcyv9gm3cg41y40b6cs9vbgxfni9md-mako-1.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mako

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/p96gppkch1b5bb84s662mcdn3gdkax3y-mako-1.1
shrinking /nix/store/p96gppkch1b5bb84s662mcdn3gdkax3y-mako-1.1/bin/mako
gzipping man pages under /nix/store/p96gppkch1b5bb84s662mcdn3gdkax3y-mako-1.1/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/p96gppkch1b5bb84s662mcdn3gdkax3y-mako-1.1/bin
patching script interpreter paths in /nix/store/p96gppkch1b5bb84s662mcdn3gdkax3y-mako-1.1
/nix/store/p96gppkch1b5bb84s662mcdn3gdkax3y-mako-1.1/bin/makoctl: interpreter directive changed from "/bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/p96gppkch1b5bb84s662mcdn3gdkax3y-mako-1.1...
/nix/store/p96gppkch1b5bb84s662mcdn3gdkax3y-mako-1.1

@dywedir
Copy link
Member Author

dywedir commented Oct 23, 2018

@xeji since we have sway-beta, this is probably good to go

@xeji xeji merged commit f7a785f into NixOS:master Oct 23, 2018
@dywedir dywedir deleted the mako branch October 23, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dywedir @GrahamcOfBorg @xeji