Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unclutter-xfixes: make systemd user unit enabled when module is #46596

Closed
wants to merge 1 commit into from

Conversation

NickHu
Copy link
Contributor

@NickHu NickHu commented Sep 13, 2018

See issue #23491; this actually fixes this small bug.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ X Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

But how? This option defaults to true.

Wouldn't something like this work?

wantedBy = [ "graphical-session.target" ];
partOf = [ "graphical-session.target" ];

@NickHu
Copy link
Contributor Author

NickHu commented Sep 13, 2018

Ah, if that's the case, then the fix mentioned in that issue is no longer required and I incorrectly associated it with applying this patch.

@worldofpeace
Copy link
Contributor

Ah, if that's the case, then the fix mentioned in that issue is no longer required

That's if the aforementioned code snippet works (i'm very sure it should).

@NickHu NickHu closed this Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants