Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsyslogd: fix broken module #47134

Closed
wants to merge 1 commit into from
Closed

rsyslogd: fix broken module #47134

wants to merge 1 commit into from

Conversation

aanderse
Copy link
Member

Motivation for this change

I've tested rsyslogd on NixOS 18.09 and no output is generated from rsyslogd at all. The module appears to be broken because of systemd changes.

According to https://wiki.archlinux.org/index.php/rsyslog "ForwardToSyslog=yes" needs to be added to journald.conf.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Sep 22, 2018

This PR appears to make it impossible to run rsyslogd without forwarding everything from journald to rsyslogd. It this really the desired behaviour?

I also thought ForwardToSyslog had been off by default several years, iirc. Am I mistaken?

@aanderse
Copy link
Member Author

@srhb Without this rsyslog produced no output at all which is not what I would expect. Is there a use case for rsyslog where it doesn't receive events from journald on NixOS?

@srhb
Copy link
Contributor

srhb commented Sep 22, 2018

@aanderse Maybe you're right. I was imagining that you might want to log other things via rsyslogd instead of just duplicating journald, but perhaps that doesn't really make sense in the presence of journald at all.

@coretemp
Copy link
Contributor

Enabling is by default and having an option to turn it off is a compromise. As a user it is typically annoying that you have to work for almost no reason.

@aanderse
Copy link
Member Author

aanderse commented Sep 22, 2018 •
edited

That sounds reasonable. Any suggestions for a new rsyslog property name?

@aanderse aanderse mentioned this pull request Sep 25, 2018
Merged
9 tasks
@aanderse
Copy link
Member Author

After thinking over your comments as well as realizing this would impact syslog-ng I'm closing this PR is favor of #47306.

Thank you for the great input, and I'd love to hear any comments you have on the new PR.

@aanderse aanderse closed this Sep 25, 2018
@aanderse aanderse deleted the rsyslog-fix branch November 4, 2018 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coretemp coretemp coretemp approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanderse @srhb @coretemp @GrahamcOfBorg