Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rage: revert to using default patched pkg-config #47125

Closed
wants to merge 1 commit into from
Closed

rage: revert to using default patched pkg-config #47125

wants to merge 1 commit into from

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Sep 21, 2018

Motivation for this change

Fixes build failure reported on #47108.

It seems that currently meson and vanilla pkg-config does work well, or there is a bug in rage related to them. For now revert to the default pkg-config (which is patched to disable resolving private requirements, used by EFL) and explicitly list the include directories that cannot be found because of that. See also #28477.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@romildo
Copy link
Contributor Author

romildo commented Sep 21, 2018

@GrahamcOfBorg build enlightenment.rage

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: enlightenment.rage

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: enlightenment.rage

Partial log (click to expand)

post-installation fixup
Wrapping program /nix/store/9zc6daab9c5fbcmvcn4hkb8ary9wrajx-rage-0.3.0/bin/rage
shrinking RPATHs of ELF executables and libraries in /nix/store/9zc6daab9c5fbcmvcn4hkb8ary9wrajx-rage-0.3.0
shrinking /nix/store/9zc6daab9c5fbcmvcn4hkb8ary9wrajx-rage-0.3.0/lib/rage/utils/rage_thumb
shrinking /nix/store/9zc6daab9c5fbcmvcn4hkb8ary9wrajx-rage-0.3.0/bin/.rage-wrapped
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9zc6daab9c5fbcmvcn4hkb8ary9wrajx-rage-0.3.0/lib  /nix/store/9zc6daab9c5fbcmvcn4hkb8ary9wrajx-rage-0.3.0/bin
patching script interpreter paths in /nix/store/9zc6daab9c5fbcmvcn4hkb8ary9wrajx-rage-0.3.0
checking for references to /build in /nix/store/9zc6daab9c5fbcmvcn4hkb8ary9wrajx-rage-0.3.0...
/nix/store/9zc6daab9c5fbcmvcn4hkb8ary9wrajx-rage-0.3.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: enlightenment.rage

Partial log (click to expand)

post-installation fixup
Wrapping program /nix/store/prd204c0s9xla529vl5nj5cljwixmk3i-rage-0.3.0/bin/rage
shrinking RPATHs of ELF executables and libraries in /nix/store/prd204c0s9xla529vl5nj5cljwixmk3i-rage-0.3.0
shrinking /nix/store/prd204c0s9xla529vl5nj5cljwixmk3i-rage-0.3.0/lib/rage/utils/rage_thumb
shrinking /nix/store/prd204c0s9xla529vl5nj5cljwixmk3i-rage-0.3.0/bin/.rage-wrapped
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/prd204c0s9xla529vl5nj5cljwixmk3i-rage-0.3.0/lib  /nix/store/prd204c0s9xla529vl5nj5cljwixmk3i-rage-0.3.0/bin
patching script interpreter paths in /nix/store/prd204c0s9xla529vl5nj5cljwixmk3i-rage-0.3.0
checking for references to /build in /nix/store/prd204c0s9xla529vl5nj5cljwixmk3i-rage-0.3.0...
/nix/store/prd204c0s9xla529vl5nj5cljwixmk3i-rage-0.3.0

@romildo romildo changed the title rage: revert to using default patched pkg-config rage: revert to using default patched pkg-config [WIP] Sep 21, 2018
@romildo romildo changed the title rage: revert to using default patched pkg-config [WIP] rage: revert to using default patched pkg-config Sep 21, 2018
@romildo
Copy link
Contributor Author

romildo commented Sep 21, 2018

Although this fixes the build failure of the package, it is not the best fix. Closing if favor of #47132.

@romildo romildo closed this Sep 21, 2018
@romildo romildo deleted the upd.enlightenment.rage branch November 10, 2018 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @GrahamcOfBorg