Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elk6Version 6.3.2 -> 6.4.1 #47118

Closed
wants to merge 1 commit into from
Closed

elk6Version 6.3.2 -> 6.4.1 #47118

wants to merge 1 commit into from

Conversation

shmish111
Copy link
Contributor

@shmish111 shmish111 commented Sep 21, 2018 •
edited

Motivation for this change

Kibana import objects doesn't work with older 6.x versions

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@shmish111
Copy link
Contributor Author

This required some small changes to the way plugins are installed but other than that it is fine. I tested this and found the ES upgrade to be fine however Kibana can end up with a corrupt index, this seems to be part of the upgrade process and not to do with this package

@Mic92
Copy link
Member

Mic92 commented Sep 21, 2018

@GrahamcOfBorg test elk

@GrahamcOfBorg
Copy link

Success on aarch64-linux

Attempted: tests.elk

No partial log is available.

@GrahamcOfBorg
Copy link

Success on x86_64-linux

Attempted: tests.elk

No partial log is available.

Mic92
Mic92 reviewed Sep 21, 2018
View reviewed changes
pkgs/servers/search/elasticsearch/plugins.nix
@@ -6,6 +6,8 @@ let
installPhase ? ''
mkdir -p $out/config
mkdir -p $out/plugins
mkdir -p $out/lib
cp -r ${elasticsearch-oss}/lib/* $out/lib/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this has ever worked for newer versions. Should we backport? @basvandijk

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does work with the previous version, doesn't really make sense to me but it does.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is @shmish111 symlinking the libraries possible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

um, don't understand :-(

Copy link
Member

@Mic92 Mic92 Sep 24, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean ln -s ${elasticsearch-oss}/lib/* $out/lib/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see, we can, what are the advantages/disadvantages?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The advantage would be less duplication.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, otherwise you will have a copy of the core libraries in each plugin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good point, ok I'll make the change today

@Mic92
Copy link
Member

Mic92 commented Sep 21, 2018

@GrahamcOfBorg test elk.ELK-5 elk.ELK-6

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.elk.ELK-5, tests.elk.ELK-6

Partial log (click to expand)

Cannot nix-instantiate `tests.elk.ELK-5' because:
error: attribute 'ELK-5' in selection path 'tests.elk.ELK-5' not found

Cannot nix-instantiate `tests.elk.ELK-6' because:
error: attribute 'ELK-6' in selection path 'tests.elk.ELK-6' not found

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: tests.elk.ELK-5, tests.elk.ELK-6

Partial log (click to expand)

one: exit status 1
syncing
one: running command: sync
one: exit status 0
test script finished in 91.87s
cleaning up
killing one (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
error: build of '/nix/store/h8vbrrdi1rkfrfj0ki5pii0klfgmh9xn-vm-test-run-ELK-6.drv' failed

@betaboon
Copy link
Contributor

@shmish111 can this be closed as as it is superseded by #51225 ?

@shmish111
Copy link
Contributor Author

Sure, closing

@shmish111 shmish111 closed this Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shmish111 @Mic92 @GrahamcOfBorg @betaboon @basvandijk