Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/hound: fix non-deterministic failure #47152

Merged
merged 1 commit into from Sep 24, 2018
Merged

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 21, 2018

Motivation for this change

The test failed on Hydra in one recent run because a request to the server was sent before indexing was finished (or even started?). Retry the request until it succeeds (or times out).

Relevant for ZHF #45960, please backport.

Things done
  • test passes in a sandbox on NixOS

cc @grahamc

The test failed on Hydra in one instance because a request to the
server was sent before indexing was finished.
Retry the request until it succeeds (or times out).
@xeji
Copy link
Contributor Author

xeji commented Sep 21, 2018

@GrahamcOfBorg test hound

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.hound

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 21.59s
cleaning up
killing machine (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/zd9558lazsp83npmph7cn7ij6lva8bpb-vm-test-run-hound

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.hound

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 20.62s
cleaning up
killing machine (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/i2gpg19kdarmad41as09by2lxzpkkxpr-vm-test-run-hound

@xeji xeji merged commit c525111 into NixOS:master Sep 24, 2018
xeji added a commit that referenced this pull request Sep 24, 2018
The test failed on Hydra in one instance because a request to the
server was sent before indexing was finished.
Retry the request until it succeeds (or times out).

(cherry picked from commit c525111)
@xeji xeji deleted the p/hound-test branch September 24, 2018 15:33
@xeji
Copy link
Contributor Author

xeji commented Sep 24, 2018

backported: 4f4807a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants