Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tensorflow: Add contrib/tensor_forest to rpath #47114

Merged
merged 1 commit into from Oct 13, 2018
Merged

tensorflow: Add contrib/tensor_forest to rpath #47114

merged 1 commit into from Oct 13, 2018

Conversation

baracoder
Copy link
Contributor

@baracoder baracoder commented Sep 21, 2018 •
edited

Motivation for this change

Fix #46841 (libforestprotos.so: cannot open shared object file)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested nox-review pr 47114 --no-merge , the other command reports no wip code
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after) (same)
  • Fits CONTRIBUTING.md.

@danieldk
Copy link
Contributor

danieldk commented Oct 2, 2018

I tested this change locally and it fixes the same problem I encountered. It would be nice if this patch could be merged, since Tensorflow is fairly useless without it (a lot of real-world projects use contrib).

@danieldk danieldk mentioned this pull request Oct 5, 2018
Closed
@FRidh
Copy link
Member

FRidh commented Oct 13, 2018

To get this in faster, cc the maintainer of the package. I typically ignore tensorflow PR's unless they approve.

@FRidh FRidh merged commit 69af83b into NixOS:master Oct 13, 2018
@baracoder
Copy link
Contributor Author

Ok, thanks

@baracoder baracoder deleted the tf-fix-contrib branch October 13, 2018 12:15
@CMCDragonkai
Copy link
Member

CMCDragonkai commented Feb 5, 2019 •
edited

Can this be backported to 18.09? Otherwise the current release's tensorflow just doesn't work.

@CMCDragonkai
Copy link
Member

Backport PR: #55257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@baracoder @danieldk @FRidh @CMCDragonkai @GrahamcOfBorg