Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ephoto: add dependency on mesa_noglu.dev #47136

Merged
merged 1 commit into from Sep 21, 2018
Merged

ephoto: add dependency on mesa_noglu.dev #47136

merged 1 commit into from Sep 21, 2018

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Sep 21, 2018

Motivation for this change

Building ephoto fails because the file gbm.pc is not being found. Adding the mesa_noglu.dev dependency fixes this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@romildo
Copy link
Contributor Author

romildo commented Sep 21, 2018

@GrahamcOfBorg build enlightenment.ephoto

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: enlightenment.ephoto

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: enlightenment.ephoto

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jrlrpq4zb8qspjg880pndif4vkswncv1-ephoto-1.5
shrinking /nix/store/jrlrpq4zb8qspjg880pndif4vkswncv1-ephoto-1.5/lib/ephoto/ephoto_thumbnail
shrinking /nix/store/jrlrpq4zb8qspjg880pndif4vkswncv1-ephoto-1.5/bin/ephoto
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jrlrpq4zb8qspjg880pndif4vkswncv1-ephoto-1.5/lib  /nix/store/jrlrpq4zb8qspjg880pndif4vkswncv1-ephoto-1.5/bin
patching script interpreter paths in /nix/store/jrlrpq4zb8qspjg880pndif4vkswncv1-ephoto-1.5
checking for references to /build in /nix/store/jrlrpq4zb8qspjg880pndif4vkswncv1-ephoto-1.5...
/nix/store/jrlrpq4zb8qspjg880pndif4vkswncv1-ephoto-1.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: enlightenment.ephoto

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/sms2mfvmasr5fhrnrxf7gnzswm9bm8wj-ephoto-1.5
shrinking /nix/store/sms2mfvmasr5fhrnrxf7gnzswm9bm8wj-ephoto-1.5/lib/ephoto/ephoto_thumbnail
shrinking /nix/store/sms2mfvmasr5fhrnrxf7gnzswm9bm8wj-ephoto-1.5/bin/ephoto
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sms2mfvmasr5fhrnrxf7gnzswm9bm8wj-ephoto-1.5/lib  /nix/store/sms2mfvmasr5fhrnrxf7gnzswm9bm8wj-ephoto-1.5/bin
patching script interpreter paths in /nix/store/sms2mfvmasr5fhrnrxf7gnzswm9bm8wj-ephoto-1.5
checking for references to /build in /nix/store/sms2mfvmasr5fhrnrxf7gnzswm9bm8wj-ephoto-1.5...
/nix/store/sms2mfvmasr5fhrnrxf7gnzswm9bm8wj-ephoto-1.5

@xeji
Copy link
Contributor

xeji commented Sep 21, 2018

Thank you!

@xeji xeji merged commit e372ab4 into NixOS:master Sep 21, 2018
xeji pushed a commit that referenced this pull request Sep 21, 2018
@romildo @xeji
ephoto: add dependency on mesa_noglu.dev (#47136)
c16b9da 
(cherry picked from commit e372ab4)
@xeji
Copy link
Contributor

xeji commented Sep 21, 2018

backported to 18.09: c16b9da

@romildo romildo deleted the fix.enlightenment.ephoto branch September 21, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @GrahamcOfBorg @xeji