Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua: 5.2.3 -> 5.2.4 #47126

Merged
merged 1 commit into from Sep 22, 2018
Merged

lua: 5.2.3 -> 5.2.4 #47126

merged 1 commit into from Sep 22, 2018

Conversation

ckauhaus
Copy link
Contributor

Motivation for this change

Lua 5.2.4 is the EOL point release of the 5.2 series.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Ubuntu)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Lua 5.2.4 is the EOL point release of the 5.2 series.
@xeji
Copy link
Contributor

xeji commented Sep 22, 2018

@GrahamcOfBorg build hydra awesome vlc

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: hydra, awesome, vlc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@xeji
Copy link
Contributor

xeji commented Sep 22, 2018

@GrahamcOfBorg build wireshark

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: awesome, vlc

The following builds were skipped because they don't evaluate on aarch64-linux: hydra

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/sfs7x9lzbr0sibil6pgsihnvp4jvsnsy-awesome-4.2
shrinking /nix/store/sfs7x9lzbr0sibil6pgsihnvp4jvsnsy-awesome-4.2/bin/.awesome-wrapped
gzipping man pages under /nix/store/sfs7x9lzbr0sibil6pgsihnvp4jvsnsy-awesome-4.2/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sfs7x9lzbr0sibil6pgsihnvp4jvsnsy-awesome-4.2/bin
patching script interpreter paths in /nix/store/sfs7x9lzbr0sibil6pgsihnvp4jvsnsy-awesome-4.2
/nix/store/sfs7x9lzbr0sibil6pgsihnvp4jvsnsy-awesome-4.2/bin/.awesome-client-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/sfs7x9lzbr0sibil6pgsihnvp4jvsnsy-awesome-4.2...
error: build of '/nix/store/z6jvsi0nrgcla2bhj21jkifp53wakr7a-vlc-3.0.3.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: hydra, awesome, vlc

Partial log (click to expand)

/nix/store/nxzki0r4dncm0hpx1p3116q7sf7lri05-vlc-3.0.3/share/vlc/utils/audio-vlc-default.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/nxzki0r4dncm0hpx1p3116q7sf7lri05-vlc-3.0.3/bin/nvlc: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/nxzki0r4dncm0hpx1p3116q7sf7lri05-vlc-3.0.3/bin/rvlc: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/nxzki0r4dncm0hpx1p3116q7sf7lri05-vlc-3.0.3/bin/qvlc: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/nxzki0r4dncm0hpx1p3116q7sf7lri05-vlc-3.0.3/bin/cvlc: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/nxzki0r4dncm0hpx1p3116q7sf7lri05-vlc-3.0.3...
postPatchMkspecs
/nix/store/lz6b43lqlx9jf4pad4944sbcl343xk3f-hydra-2018-08-07
/nix/store/p5c34dm9w6pmnqpk74nwbrd1bglybknf-awesome-4.2
/nix/store/nxzki0r4dncm0hpx1p3116q7sf7lri05-vlc-3.0.3

@xeji
Copy link
Contributor

xeji commented Sep 22, 2018

@GrahamcOfBorg build lua

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: wireshark

Partial log (click to expand)

/nix/store/686zri3sc4790j65xwj102k8h5d5i63f-wireshark-qt-2.6.3/lib/libwireshark.11.1.3.dylib: fixing dylib
/nix/store/686zri3sc4790j65xwj102k8h5d5i63f-wireshark-qt-2.6.3/Applications/Wireshark.app/Contents/Frameworks/libwiretap.8.0.3.dylib: fixing dylib
/nix/store/686zri3sc4790j65xwj102k8h5d5i63f-wireshark-qt-2.6.3/Applications/Wireshark.app/Contents/Frameworks/libwsutil.9.0.0.dylib: fixing dylib
/nix/store/686zri3sc4790j65xwj102k8h5d5i63f-wireshark-qt-2.6.3/Applications/Wireshark.app/Contents/Frameworks/libwscodecs.2.0.0.dylib: fixing dylib
/nix/store/686zri3sc4790j65xwj102k8h5d5i63f-wireshark-qt-2.6.3/Applications/Wireshark.app/Contents/Frameworks/libwireshark.11.1.3.dylib: fixing dylib
/nix/store/686zri3sc4790j65xwj102k8h5d5i63f-wireshark-qt-2.6.3/lib/libwiretap.8.0.3.dylib: fixing dylib
/nix/store/686zri3sc4790j65xwj102k8h5d5i63f-wireshark-qt-2.6.3/lib/libwsutil.9.0.0.dylib: fixing dylib
/nix/store/686zri3sc4790j65xwj102k8h5d5i63f-wireshark-qt-2.6.3/lib/libwscodecs.2.0.0.dylib: fixing dylib
/nix/store/686zri3sc4790j65xwj102k8h5d5i63f-wireshark-qt-2.6.3/lib/libwireshark.11.1.3.dylib: fixing dylib
postPatchMkspecs

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: lua

Partial log (click to expand)

/nix/store/3j8s75zamc7sicpawszdk6i5ljwl41s2-lua-5.2.4

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: lua

Partial log (click to expand)

cd src && cp -d liblua.5.2.4.dylib /nix/store/jn4cqfhqikdk0p71ickylaym2z60gc7h-lua-5.2.4/lib
cd doc && cp -d lua.1 luac.1 /nix/store/jn4cqfhqikdk0p71ickylaym2z60gc7h-lua-5.2.4/share/man/man1
ln -s -f liblua.5.2.4.dylib /nix/store/jn4cqfhqikdk0p71ickylaym2z60gc7h-lua-5.2.4/lib/liblua.5.2.dylib
ln -s -f liblua.5.2.dylib /nix/store/jn4cqfhqikdk0p71ickylaym2z60gc7h-lua-5.2.4/lib/liblua.dylib
post-installation fixup
gzipping man pages under /nix/store/jn4cqfhqikdk0p71ickylaym2z60gc7h-lua-5.2.4/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/jn4cqfhqikdk0p71ickylaym2z60gc7h-lua-5.2.4/lib  /nix/store/jn4cqfhqikdk0p71ickylaym2z60gc7h-lua-5.2.4/bin
patching script interpreter paths in /nix/store/jn4cqfhqikdk0p71ickylaym2z60gc7h-lua-5.2.4
/nix/store/jn4cqfhqikdk0p71ickylaym2z60gc7h-lua-5.2.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: lua

Partial log (click to expand)

/nix/store/g5d2jki3nmpq2mksf8k5psnbs9f0mrfd-lua-5.2.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: wireshark

Partial log (click to expand)

shrinking /nix/store/08dn80339hkjiizi26yg24g6hhcc66z8-wireshark-qt-2.6.3/bin/sharkd
shrinking /nix/store/08dn80339hkjiizi26yg24g6hhcc66z8-wireshark-qt-2.6.3/bin/rawshark
shrinking /nix/store/08dn80339hkjiizi26yg24g6hhcc66z8-wireshark-qt-2.6.3/bin/tshark
gzipping man pages under /nix/store/08dn80339hkjiizi26yg24g6hhcc66z8-wireshark-qt-2.6.3/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/08dn80339hkjiizi26yg24g6hhcc66z8-wireshark-qt-2.6.3/lib  /nix/store/08dn80339hkjiizi26yg24g6hhcc66z8-wireshark-qt-2.6.3/bin
patching script interpreter paths in /nix/store/08dn80339hkjiizi26yg24g6hhcc66z8-wireshark-qt-2.6.3
checking for references to /build in /nix/store/08dn80339hkjiizi26yg24g6hhcc66z8-wireshark-qt-2.6.3...
postPatchMkspecs
/nix/store/08dn80339hkjiizi26yg24g6hhcc66z8-wireshark-qt-2.6.3

@xeji
Copy link
Contributor

xeji commented Sep 22, 2018

vlc failure on aarch64 is unrelated

@xeji xeji merged commit 6adb944 into NixOS:master Sep 22, 2018
xeji pushed a commit that referenced this pull request Sep 22, 2018
Lua 5.2.4 is the EOL point release of the 5.2 series.

(cherry picked from commit 6adb944)
@xeji
Copy link
Contributor

xeji commented Sep 22, 2018

backported to 18.09: b831700

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wireshark

Partial log (click to expand)

shrinking /nix/store/vwkn7kkr6c7f1bsqjyy18plgks925bdi-wireshark-qt-2.6.3/bin/tshark
shrinking /nix/store/vwkn7kkr6c7f1bsqjyy18plgks925bdi-wireshark-qt-2.6.3/bin/text2pcap
shrinking /nix/store/vwkn7kkr6c7f1bsqjyy18plgks925bdi-wireshark-qt-2.6.3/bin/editcap
shrinking /nix/store/vwkn7kkr6c7f1bsqjyy18plgks925bdi-wireshark-qt-2.6.3/bin/capinfos
gzipping man pages under /nix/store/vwkn7kkr6c7f1bsqjyy18plgks925bdi-wireshark-qt-2.6.3/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vwkn7kkr6c7f1bsqjyy18plgks925bdi-wireshark-qt-2.6.3/lib  /nix/store/vwkn7kkr6c7f1bsqjyy18plgks925bdi-wireshark-qt-2.6.3/bin
patching script interpreter paths in /nix/store/vwkn7kkr6c7f1bsqjyy18plgks925bdi-wireshark-qt-2.6.3
checking for references to /build in /nix/store/vwkn7kkr6c7f1bsqjyy18plgks925bdi-wireshark-qt-2.6.3...
postPatchMkspecs

@ckauhaus ckauhaus deleted the lua-5.2.4 branch September 24, 2018 07:54
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants