cryus-sasl: cleanup, fix w/musl (although not at all musl-specific) #47129
Conversation
|
Hopefully 2.1.27 is soon and is much less broken regarding autoconf/libtool bits. Looks like we're in the minority for not having a big stack of patches for this already. |
|
staging seems appropriate: https://gist.github.com/GrahamcOfBorg/5308396b96f7eb5c758a7fa7c5193585 |
musl is fixed by disabling update of config.{guess,sub}.
dtzWill
force-pushed
the
fix/cyrus-sasl-musl
branch
from
6465817
to
90268ef
Compare
dtzWill
requested review from
Ericson2314,
FRidh,
LnL7 and
Mic92
as code owners
|
Good call, and sorry for the review-invite spam after rebase. |
GrahamcOfBorg
added
6.topic: GNOME
| ''; | ||
| # Avoid triggering regenerating using broken autoconf/libtool bits. | ||
| # (many distributions carry patches to remove/replace, but this works for now) | ||
| dontUpdateAutotoolsGnuConfigScripts = true; |
There was a problem hiding this comment.
I wonder why this breaks things?
There was a problem hiding this comment.
Maybe set it to null if not musl.
There was a problem hiding this comment.
I don't think it will work on any platform, it's just that only musl and aarch64 (IIRC) automatically attempt to do this for all packages. And it seems better to ensure it doesn't happen than hope the boolean expression here is always up-to-date with the list of platforms that add the auto-update-config-guess setup hook...?
There was a problem hiding this comment.
Yeah makes sense. I wonder if it just needs to regenerate some files though? Changing the config.* files should be harmless.
Unclear what the problem is exactly regarding regenerating files, so this makes the change only impact build configs known to need it.
|
Alright I'll just set to null on non-musl. Thanks! |
GrahamcOfBorg
removed
6.topic: GNOME
musl is fixed by disabling update of config.{guess,sub}.
Let's check how this fares on Aarch64, since that platform (I think?)
also automatically updates these files by default.
Fixes #47105.
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)