Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jabref: 3.8.1 -> 4.3.1 #47113

Closed
wants to merge 2 commits into from
Closed

jabref: 3.8.1 -> 4.3.1 #47113

wants to merge 2 commits into from

Conversation

layus
Copy link
Member

@layus layus commented Sep 21, 2018

Previous version is one year old.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
  • Tested execution of all binary files (usually in ./result/bin/)

/cc @gebner

@layus layus changed the title jabref: 3.8.1 -> 4.3.1 [WIP] jabref: 3.8.1 -> 4.3.1 Sep 21, 2018
@layus layus changed the title [WIP] jabref: 3.8.1 -> 4.3.1 jabref: 3.8.1 -> 4.3.1 Sep 21, 2018
@gebner
Copy link
Member

gebner commented Sep 22, 2018

The main downside of this change is that we now use the unfree oraclejdk. Ideally we could package openjfx instead, and keep using openjdk.

@layus
Copy link
Member Author

layus commented Sep 22, 2018

And also that oraclejdk is not packaged for Darwin. Do you have any idea of what it would take to packages openjfx ?

@gebner
Copy link
Member

gebner commented Sep 22, 2018

See #16727. @mekeor (user now deleted) started to write an openjfx overlay once: #16727 (comment) But I don't think it worked.

@Mic92
Copy link
Member

Mic92 commented Sep 24, 2018

Is it better to switch to oraclejdk or leave the old version as it is?

@gebner
Copy link
Member

gebner commented Sep 24, 2018

Another "solution" is to switch to jetbrains.jdk on linux, which happens to include javafx.

@layus
Copy link
Member Author

layus commented Sep 25, 2018

Okay, there is no consensus on this. @gebner Feel free to do whatever you think best. I am closing this PR in the meantime. Maybe an issue would be better to track the status of this ?

@layus layus closed this Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants