Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abduco: refactor (compile on darwin) #47124

Merged
merged 2 commits into from Sep 22, 2018
Merged

abduco: refactor (compile on darwin) #47124

merged 2 commits into from Sep 22, 2018

Conversation

luke-clifton
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented Sep 21, 2018

@GrahamcOfBorg build abduco

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: abduco

Partial log (click to expand)

installing manual page to /nix/store/48pn65lhk9s5lqwzni8yz450zkkk1haf-abduco-0.6/share/man/man1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/48pn65lhk9s5lqwzni8yz450zkkk1haf-abduco-0.6
shrinking /nix/store/48pn65lhk9s5lqwzni8yz450zkkk1haf-abduco-0.6/bin/abduco
gzipping man pages under /nix/store/48pn65lhk9s5lqwzni8yz450zkkk1haf-abduco-0.6/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/48pn65lhk9s5lqwzni8yz450zkkk1haf-abduco-0.6/bin
patching script interpreter paths in /nix/store/48pn65lhk9s5lqwzni8yz450zkkk1haf-abduco-0.6
checking for references to /build in /nix/store/48pn65lhk9s5lqwzni8yz450zkkk1haf-abduco-0.6...
/nix/store/48pn65lhk9s5lqwzni8yz450zkkk1haf-abduco-0.6

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: abduco

Partial log (click to expand)

installing
stripping executable
installing executable file to /nix/store/z4v3q5f0jx77fbwm4qy80kmzk1qdpl45-abduco-0.6/bin
installing manual page to /nix/store/z4v3q5f0jx77fbwm4qy80kmzk1qdpl45-abduco-0.6/share/man/man1
post-installation fixup
gzipping man pages under /nix/store/z4v3q5f0jx77fbwm4qy80kmzk1qdpl45-abduco-0.6/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/z4v3q5f0jx77fbwm4qy80kmzk1qdpl45-abduco-0.6/bin
patching script interpreter paths in /nix/store/z4v3q5f0jx77fbwm4qy80kmzk1qdpl45-abduco-0.6
/nix/store/z4v3q5f0jx77fbwm4qy80kmzk1qdpl45-abduco-0.6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: abduco

Partial log (click to expand)

installing manual page to /nix/store/wpwygf1iiyf4cgggmkq29n4w0k36rn1d-abduco-0.6/share/man/man1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wpwygf1iiyf4cgggmkq29n4w0k36rn1d-abduco-0.6
shrinking /nix/store/wpwygf1iiyf4cgggmkq29n4w0k36rn1d-abduco-0.6/bin/abduco
gzipping man pages under /nix/store/wpwygf1iiyf4cgggmkq29n4w0k36rn1d-abduco-0.6/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wpwygf1iiyf4cgggmkq29n4w0k36rn1d-abduco-0.6/bin
patching script interpreter paths in /nix/store/wpwygf1iiyf4cgggmkq29n4w0k36rn1d-abduco-0.6
checking for references to /build in /nix/store/wpwygf1iiyf4cgggmkq29n4w0k36rn1d-abduco-0.6...
/nix/store/wpwygf1iiyf4cgggmkq29n4w0k36rn1d-abduco-0.6

@luke-clifton
abduco: refactor
1b6d1b0 
Add platforms list.
@joachifm joachifm merged commit 3d8f6b6 into NixOS:master Sep 22, 2018
LnL7 pushed a commit that referenced this pull request Sep 25, 2018
@luke-clifton @LnL7
abduco: refactor (compile on darwin) (#47124)
67e53e0 
(cherry picked from commit 3d8f6b6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 left review comments

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@luke-clifton @LnL7 @GrahamcOfBorg @joachifm