Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backblaze-b2: Fix autocompletion support #46004

Merged
merged 1 commit into from Sep 3, 2018
Merged

backblaze-b2: Fix autocompletion support #46004

merged 1 commit into from Sep 3, 2018

Conversation

uskudnik
Copy link
Contributor

@uskudnik uskudnik commented Sep 3, 2018 •
edited

Motivation for this change

backblaze v1.3.6 incorporates a fix for autocompletion that replaced have function with _have. The postInstall hook therefore needs to be updated to replace _have.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@uskudnik
backblaze-b2: Fix autocompletion support
b863062 
backblaze v1.3.6 incorporates[1] a fix[2] for autocompletion that replaced
`have` function with `_have`. The postInstall hook therefore needs
to be updated to replace `_have`.

[1] https://github.com/Backblaze/B2_Command_Line_Tool#136-august-21-2018
[2] Backblaze/B2_Command_Line_Tool#497
@domenkozar domenkozar merged commit 882f6c9 into NixOS:master Sep 3, 2018
@uskudnik uskudnik deleted the backblaze-b2-fix-autocompletion branch July 30, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@uskudnik @domenkozar @GrahamcOfBorg