Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mxnet: 1.1.0 -> 1.2.1 #46026

Merged
merged 1 commit into from Sep 4, 2018
Merged

mxnet: 1.1.0 -> 1.2.1 #46026

merged 1 commit into from Sep 4, 2018

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Sep 4, 2018

Update and fix the build:

  • Perl is a build-time requirement.
  • Fix hardcoded /bin/bash invocation.
Motivation for this change

Build fails in 18.09, ZHF #45960.

(I plan to look at the Python mxnet module afterwards.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@danieldk
mxnet: 1.1.0 -> 1.2.1
f412143 
Update and fix the build:

- Perl is a build-time requirement.
- Fix hardcoded /bin/bash invocation.
@xeji
Copy link
Contributor

xeji commented Sep 4, 2018

@GrahamcOfBorg build mxnet python36Packages.mxnet python27Packages.mxnet

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: mxnet, python36Packages.mxnet, python27Packages.mxnet

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: mxnet, python36Packages.mxnet, python27Packages.mxnet

Partial log (click to expand)

../configure: line 485: can't create lib/Makefile: nonexistent directory
../configure: line 541: can't create lib/Makefile: nonexistent directory
DONE configure
/nix/store/pjq5v1xgljr4ygb1h1xfybdjydczcqiw-stdenv-linux/setup: line 100: include/atlas_cacheedge.h: No such file or directory
builder for '/nix/store/cikyqczmwfpn9jj8bnihwgssf2mnp4hv-atlas-3.10.3.drv' failed with exit code 1
cannot build derivation '/nix/store/yxh1q331jvpgkm4r6q7rz0m9ybjwc40b-liblapack-3.8.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/6xz8rh782ihmwdmcsspggh0ii0x39gkl-mxnet-1.2.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/2ml20xgpqjdgnx0x57i7v7vha4sc65ih-python2.7-mxnet-1.2.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/dwpwm2p74hxgfiyk50ig52ppr6d8kf0k-python3.6-mxnet-1.2.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/2ml20xgpqjdgnx0x57i7v7vha4sc65ih-python2.7-mxnet-1.2.1.drv', '/nix/store/6xz8rh782ihmwdmcsspggh0ii0x39gkl-mxnet-1.2.1.drv', '/nix/store/dwpwm2p74hxgfiyk50ig52ppr6d8kf0k-python3.6-mxnet-1.2.1.drv' failed

@xeji
Copy link
Contributor

xeji commented Sep 4, 2018

aarch64 failure is in a dependency, can be ignored for this PR.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: mxnet, python36Packages.mxnet, python27Packages.mxnet

Partial log (click to expand)

/nix/store/8ng1kdflixqzwwbd705nlm1ry4pwfmcp-python3.6-bootstrapped-pip-18.0/lib/python3.6/site-packages/wheel/metadata.py:16: DeprecationWarning: invalid escape sequence \s
  EXTRA_RE = re.compile("""^(?P<package>.*?)(;\s*(?P<condition>.*?)(extra == '(?P<extra>.*?)')?)$""")
installing
/build/apache-mxnet-src-1.2.1-incubating/python/dist /build/apache-mxnet-src-1.2.1-incubating/python
Processing ./mxnet-1.2.1-py3-none-any.whl
Collecting numpy<=1.15.0,>=1.8.2 (from mxnet==1.2.1)
  Could not find a version that satisfies the requirement numpy<=1.15.0,>=1.8.2 (from mxnet==1.2.1) (from versions: )
No matching distribution found for numpy<=1.15.0,>=1.8.2 (from mxnet==1.2.1)
builder for '/nix/store/m828ragaw6nwf6kbnzsmqg4kzi8qivmj-python3.6-mxnet-1.2.1.drv' failed with exit code 1
error: build of '/nix/store/4b5ngv028n14aq0d5z7gk5qfrar9gdk1-python2.7-mxnet-1.2.1.drv', '/nix/store/m828ragaw6nwf6kbnzsmqg4kzi8qivmj-python3.6-mxnet-1.2.1.drv' failed

@xeji
Copy link
Contributor

xeji commented Sep 4, 2018

(I plan to look at the Python mxnet module afterwards.)

mxnet builds, so this PR is good to merge.

@xeji xeji merged commit 93a5947 into NixOS:master Sep 4, 2018
xeji pushed a commit that referenced this pull request Sep 4, 2018
@danieldk @xeji
mxnet: 1.1.0 -> 1.2.1 (#46026)
4b666f1 
Update and fix the build:

- Perl is a build-time requirement.
- Fix hardcoded /bin/bash invocation.

(cherry picked from commit 93a5947)
@xeji
Copy link
Contributor

xeji commented Sep 4, 2018

backported in 4b666f1

@danieldk danieldk deleted the mxnet-1.2.1 branch September 5, 2018 14:25
@danieldk danieldk restored the mxnet-1.2.1 branch September 5, 2018 14:25
@danieldk danieldk deleted the mxnet-1.2.1 branch September 5, 2018 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @xeji @GrahamcOfBorg