Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openblas: fix pkg-config alias name #46016

Merged
merged 1 commit into from Sep 3, 2018
Merged

openblas: fix pkg-config alias name #46016

merged 1 commit into from Sep 3, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Sep 3, 2018

Motivation for this change

Fixup for #45257 (which I already had locally but forgot to push to that PR before merging).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau
openblas: fix pkg-config alias name
408eacb 
Turns out the filename is important. It should be `cblas`, not
`openblas-cblas`.
@timokau timokau changed the base branch from master to staging September 3, 2018 22:00
@timokau timokau changed the title Openblas fix openblas: fix pkg-config alias name Sep 3, 2018
@timokau timokau merged commit a774988 into NixOS:staging Sep 3, 2018
@timokau timokau deleted the openblas-fix branch September 3, 2018 22:01
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: openblas

Partial log (click to expand)

Install OK!
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/p5fa0aqyd5bmlppsdsjzkfwn072d6kbv-openblas-0.3.1
shrinking /nix/store/p5fa0aqyd5bmlppsdsjzkfwn072d6kbv-openblas-0.3.1/lib/libopenblas_armv8p-r0.3.1.so
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/p5fa0aqyd5bmlppsdsjzkfwn072d6kbv-openblas-0.3.1/lib  /nix/store/p5fa0aqyd5bmlppsdsjzkfwn072d6kbv-openblas-0.3.1/bin
patching script interpreter paths in /nix/store/p5fa0aqyd5bmlppsdsjzkfwn072d6kbv-openblas-0.3.1
checking for references to /build in /nix/store/p5fa0aqyd5bmlppsdsjzkfwn072d6kbv-openblas-0.3.1...
/nix/store/p5fa0aqyd5bmlppsdsjzkfwn072d6kbv-openblas-0.3.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openblas

Partial log (click to expand)

Generating OpenBLASConfigVersion.cmake in /nix/store/kdydfbazf3smj2s7w3kgc3n8rs4da1gr-openblas-0.3.1/lib/cmake/openblas
Install OK!
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kdydfbazf3smj2s7w3kgc3n8rs4da1gr-openblas-0.3.1
shrinking /nix/store/kdydfbazf3smj2s7w3kgc3n8rs4da1gr-openblas-0.3.1/lib/libopenblasp-r0.3.1.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kdydfbazf3smj2s7w3kgc3n8rs4da1gr-openblas-0.3.1/lib  /nix/store/kdydfbazf3smj2s7w3kgc3n8rs4da1gr-openblas-0.3.1/bin
patching script interpreter paths in /nix/store/kdydfbazf3smj2s7w3kgc3n8rs4da1gr-openblas-0.3.1
checking for references to /build in /nix/store/kdydfbazf3smj2s7w3kgc3n8rs4da1gr-openblas-0.3.1...

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: openblas

Partial log (click to expand)

cannot build derivation '/nix/store/gv5yn93nkjaw027aibsssn6x42n501rp-mpfr-4.0.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/nw5h61jr39cl45bm9dlwxhbpbg6cscm1-perl-5.28.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/z2jmxfhh8bhjlp1ykb8485jk8xr97i7w-which-2.21.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ypr7acy0danajssfmsb4f1mkgmxwcsvq-libelf-0.8.13.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/4nyg6sa19skw072i42laldxz788nzdq3-libmpc-1.1.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/wyp5wksw03q1pz3s3dybfykk7l1jzj9h-texinfo-6.5.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/x3xphhqpddxlrhb7a17gq7m644pz8krp-gfortran-7.3.0.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/3z08nfqma43rmz3y1pp7wjjmnhg4yfs6-gfortran-wrapper-7.3.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/az5fqv1jmllysp8l61qn6s27baylzyy2-openblas-0.3.1.drv': 4 dependencies couldn't be built
error: build of '/nix/store/az5fqv1jmllysp8l61qn6s27baylzyy2-openblas-0.3.1.drv' failed

@timokau timokau mentioned this pull request Sep 4, 2018
Closed
vcunat pushed a commit that referenced this pull request Sep 4, 2018
@timokau @vcunat
Merge #46016: openblas: fix pkg-config alias name
6f8e07a 
(cherry picked from commit a774988)
@timokau timokau mentioned this pull request Sep 7, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: stdenv Standard environment 8.has: changelog 8.has: documentation 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg