Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kodi: fix nfs support #46006

Merged
merged 1 commit into from Sep 3, 2018
Merged

kodi: fix nfs support #46006

merged 1 commit into from Sep 3, 2018

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Sep 3, 2018

Currently nfs support is broken in kodi on NixOS because libnfs is required to be in the LD_LIBRARY_PATH.

see: https://www.reddit.com/r/NixOS/comments/9aiquo/how_to_enable_nfs_support_in_kodi/

Motivation for this change

Fix nfs support in kodi. I would suggest this is change is minor enough it could be backported to 18.09 as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 modified the milestones: 19.03, 18.03 Sep 3, 2018
@xeji
Copy link
Contributor

xeji commented Sep 3, 2018

@GrahamcOfBorg build kodi

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: kodi

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: kodi

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kodi

Partial log (click to expand)

/nix/store/v7kr9w76qfhm5h7hchvarw1k95v4b7ws-kodi-17.6/lib/python2.7/dist-packages/kodi/ps3/sixpair.py: interpreter directive changed from "/usr/bin/python" to "/nix/store/6b6lzbq74g95j8qlbrdjzkn2ghh81mgy-python-2.7.15/bin/python"
/nix/store/v7kr9w76qfhm5h7hchvarw1k95v4b7ws-kodi-17.6/lib/python2.7/dist-packages/kodi/zeroconf.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/6b6lzbq74g95j8qlbrdjzkn2ghh81mgy-python-2.7.15/bin/python"
/nix/store/v7kr9w76qfhm5h7hchvarw1k95v4b7ws-kodi-17.6/lib/python2.7/dist-packages/kodi/ps3_remote.py: interpreter directive changed from "/usr/bin/python" to "/nix/store/6b6lzbq74g95j8qlbrdjzkn2ghh81mgy-python-2.7.15/bin/python"
/nix/store/v7kr9w76qfhm5h7hchvarw1k95v4b7ws-kodi-17.6/lib/python2.7/dist-packages/kodi/xbmcclient.py: interpreter directive changed from "/usr/bin/python" to "/nix/store/6b6lzbq74g95j8qlbrdjzkn2ghh81mgy-python-2.7.15/bin/python"
checking for references to /build in /nix/store/v7kr9w76qfhm5h7hchvarw1k95v4b7ws-kodi-17.6...
running install tests
17.6 Git:20171115 Media Center Kodi
Copyright (C) 2005-2013 Team Kodi - http://kodi.tv
building '/nix/store/awgh3ifxbywgfigsl7hfyp56xvzikwhx-kodi-17.6.drv'...
ln: failed to create symbolic link '/nix/store/d1a1rc0a6yqav0qw0icqgnfgidixzswy-kodi-17.6/share/kodi/./addons': File exists

@xeji xeji merged commit 435eccf into NixOS:master Sep 3, 2018
xeji pushed a commit that referenced this pull request Sep 3, 2018
@aanderse @xeji
kodi: fix nfs support (#46006)
427ac1a 
libnfs is required to be in the LD_LIBRARY_PATH for kodi if you want nfs support 
see: https://www.reddit.com/r/NixOS/comments/9aiquo/how_to_enable_nfs_support_in_kodi/

(cherry picked from commit 435eccf)
xeji pushed a commit that referenced this pull request Sep 3, 2018
@aanderse @xeji
kodi: fix nfs support (#46006)
f82b65b 
libnfs is required to be in the LD_LIBRARY_PATH for kodi if you want nfs support 
see: https://www.reddit.com/r/NixOS/comments/9aiquo/how_to_enable_nfs_support_in_kodi/

(cherry picked from commit 435eccf)
@xeji
Copy link
Contributor

xeji commented Sep 3, 2018

backported in 427ac1a and f82b65b

@aanderse aanderse deleted the kodi-nfs-fix branch September 3, 2018 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
18.03
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanderse @xeji @GrahamcOfBorg @Mic92