Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prettyping: init 1.0.1 #46008

Merged
merged 1 commit into from Sep 5, 2018
Merged

prettyping: init 1.0.1 #46008

merged 1 commit into from Sep 5, 2018

Conversation

qoelet
Copy link
Member

@qoelet qoelet commented Sep 3, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 3, 2018

@GrahamcOfBorg build prettyping

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: prettyping

Partial log (click to expand)

Cannot nix-instantiate `prettyping' because:
error: attribute 'prettyping' in selection path 'prettyping' not found

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: prettyping

Partial log (click to expand)

Cannot nix-instantiate `prettyping' because:
error: attribute 'prettyping' in selection path 'prettyping' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: prettyping

Partial log (click to expand)

Cannot nix-instantiate `prettyping' because:
error: attribute 'prettyping' in selection path 'prettyping' not found

xeji
xeji suggested changes Sep 3, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add the package to top-level/all-packages.nix to be able to build and use it.

pkgs/tools/networking/prettyping/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/prettyping/default.nix Outdated Show resolved Hide resolved
@qoelet
Copy link
Member Author

qoelet commented Sep 5, 2018

@xeji I've updated the PR. Thanks!

@xeji
Copy link
Contributor

xeji commented Sep 5, 2018

@GrahamcOfBorg build prettyping

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: prettyping

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: prettyping

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hybdncbvjw1z271ndfsp4qqysjzbzw3v-prettyping-1.0.1
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hybdncbvjw1z271ndfsp4qqysjzbzw3v-prettyping-1.0.1/bin
patching script interpreter paths in /nix/store/hybdncbvjw1z271ndfsp4qqysjzbzw3v-prettyping-1.0.1
/nix/store/hybdncbvjw1z271ndfsp4qqysjzbzw3v-prettyping-1.0.1/bin/prettyping: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/hybdncbvjw1z271ndfsp4qqysjzbzw3v-prettyping-1.0.1...
/nix/store/hybdncbvjw1z271ndfsp4qqysjzbzw3v-prettyping-1.0.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: prettyping

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pfhnr8hhd0w3fwkyldg3sp7vahc6vqbc-prettyping-1.0.1
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pfhnr8hhd0w3fwkyldg3sp7vahc6vqbc-prettyping-1.0.1/bin
patching script interpreter paths in /nix/store/pfhnr8hhd0w3fwkyldg3sp7vahc6vqbc-prettyping-1.0.1
/nix/store/pfhnr8hhd0w3fwkyldg3sp7vahc6vqbc-prettyping-1.0.1/bin/prettyping: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/pfhnr8hhd0w3fwkyldg3sp7vahc6vqbc-prettyping-1.0.1...
/nix/store/pfhnr8hhd0w3fwkyldg3sp7vahc6vqbc-prettyping-1.0.1

@xeji xeji merged commit 7e0dd4c into NixOS:master Sep 5, 2018
@qoelet qoelet deleted the prettyping branch September 5, 2018 06:31
@xeji xeji mentioned this pull request Sep 5, 2018
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qoelet @xeji @GrahamcOfBorg