Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rdy] pythonPackages.alot: install zsh completion #45996

Merged
merged 1 commit into from Sep 6, 2018
Merged

[rdy] pythonPackages.alot: install zsh completion #45996

merged 1 commit into from Sep 6, 2018

Conversation

teto
Copy link
Member

@teto teto commented Sep 3, 2018 •
edited

Motivation for this change

provide zsh completion

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@teto teto requested a review from FRidh as a code owner September 3, 2018 17:24
@teto
Copy link
Member Author

teto commented Sep 6, 2018

pinging @Mic92 since you merged a similar zsh completion Pr recently :)

@Mic92 Mic92 merged commit 89571b2 into NixOS:master Sep 6, 2018
@teto teto deleted the alot_completion branch May 13, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teto @Mic92 @GrahamcOfBorg