Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magit-todos: fix build by providing git as input. #45999

Merged
merged 1 commit into from Sep 3, 2018
Merged

magit-todos: fix build by providing git as input. #45999

merged 1 commit into from Sep 3, 2018

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Sep 3, 2018

magit-todos requires git during builds. Fixes #45868.

Motivation for this change

magit-todos build fails because git is required at build time.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@danieldk
magit-todos: fix build by providing git as input.
194a1f9 
magit-todos requires git during builds. Fixes NixOS#45868.
@xeji
Copy link
Contributor

xeji commented Sep 3, 2018

@GrahamcOfBorg build emacsPackagesNg.magit-todos

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: emacsPackagesNg.magit-todos

Partial log (click to expand)

Compiling /nix/store/9gl86wldnmmc8jvmnvxlnl6icsapp4dp-emacs-magit-todos-20180716.2339/share/emacs/site-lisp/elpa/magit-todos-20180716.2339/magit-todos-autoloads.el...
Compiling /nix/store/9gl86wldnmmc8jvmnvxlnl6icsapp4dp-emacs-magit-todos-20180716.2339/share/emacs/site-lisp/elpa/magit-todos-20180716.2339/magit-todos-pkg.el...
Compiling /nix/store/9gl86wldnmmc8jvmnvxlnl6icsapp4dp-emacs-magit-todos-20180716.2339/share/emacs/site-lisp/elpa/magit-todos-20180716.2339/magit-todos.el...
Done (Total of 1 file compiled, 2 skipped)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9gl86wldnmmc8jvmnvxlnl6icsapp4dp-emacs-magit-todos-20180716.2339
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/9gl86wldnmmc8jvmnvxlnl6icsapp4dp-emacs-magit-todos-20180716.2339
checking for references to /build in /nix/store/9gl86wldnmmc8jvmnvxlnl6icsapp4dp-emacs-magit-todos-20180716.2339...
/nix/store/9gl86wldnmmc8jvmnvxlnl6icsapp4dp-emacs-magit-todos-20180716.2339

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: emacsPackagesNg.magit-todos

Partial log (click to expand)

Compiling /nix/store/5qzqmswd9kldjjhcc6faa6i3b6cack2v-emacs-magit-todos-20180716.2339/share/emacs/site-lisp/elpa/magit-todos-20180716.2339/magit-todos-autoloads.el...
Compiling /nix/store/5qzqmswd9kldjjhcc6faa6i3b6cack2v-emacs-magit-todos-20180716.2339/share/emacs/site-lisp/elpa/magit-todos-20180716.2339/magit-todos-pkg.el...
Compiling /nix/store/5qzqmswd9kldjjhcc6faa6i3b6cack2v-emacs-magit-todos-20180716.2339/share/emacs/site-lisp/elpa/magit-todos-20180716.2339/magit-todos.el...
Done (Total of 1 file compiled, 2 skipped)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5qzqmswd9kldjjhcc6faa6i3b6cack2v-emacs-magit-todos-20180716.2339
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/5qzqmswd9kldjjhcc6faa6i3b6cack2v-emacs-magit-todos-20180716.2339
checking for references to /build in /nix/store/5qzqmswd9kldjjhcc6faa6i3b6cack2v-emacs-magit-todos-20180716.2339...
/nix/store/5qzqmswd9kldjjhcc6faa6i3b6cack2v-emacs-magit-todos-20180716.2339

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: emacsPackagesNg.magit-todos

Partial log (click to expand)

Wrote /nix/store/nbxk9wbz9466fqxysld5j429rp4xv0yl-emacs-magit-todos-20180716.2339/share/emacs/site-lisp/elpa/magit-todos-20180716.2339/magit-todos-autoloads.el
Checking /nix/store/nbxk9wbz9466fqxysld5j429rp4xv0yl-emacs-magit-todos-20180716.2339/share/emacs/site-lisp/elpa/magit-todos-20180716.2339...
Compiling /nix/store/nbxk9wbz9466fqxysld5j429rp4xv0yl-emacs-magit-todos-20180716.2339/share/emacs/site-lisp/elpa/magit-todos-20180716.2339/magit-todos-autoloads.el...
Compiling /nix/store/nbxk9wbz9466fqxysld5j429rp4xv0yl-emacs-magit-todos-20180716.2339/share/emacs/site-lisp/elpa/magit-todos-20180716.2339/magit-todos-pkg.el...
Compiling /nix/store/nbxk9wbz9466fqxysld5j429rp4xv0yl-emacs-magit-todos-20180716.2339/share/emacs/site-lisp/elpa/magit-todos-20180716.2339/magit-todos.el...
Done (Total of 1 file compiled, 2 skipped)
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/nbxk9wbz9466fqxysld5j429rp4xv0yl-emacs-magit-todos-20180716.2339
/nix/store/nbxk9wbz9466fqxysld5j429rp4xv0yl-emacs-magit-todos-20180716.2339

@xeji xeji merged commit 9d6ff38 into NixOS:master Sep 3, 2018
xeji pushed a commit that referenced this pull request Sep 3, 2018
@danieldk @xeji
magit-todos: fix build by providing git as input. (#45999)
d0182e0 
magit-todos requires git during builds. Fixes #45868.

(cherry picked from commit 9d6ff38)
@xeji
Copy link
Contributor

xeji commented Sep 3, 2018

backported in d0182e0

@danieldk danieldk deleted the magit-todos branch September 5, 2018 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @xeji @GrahamcOfBorg