Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos: initrd/luks: make uuid specified devices discoverable #45998

Merged
merged 1 commit into from Sep 24, 2018

Conversation

edwtjo
Copy link
Member

@edwtjo edwtjo commented Sep 3, 2018

Motivation for this change

Previously it was possible to use uuid specifiers in encrypted.blkDev="UUID=XXXXXXXX-YYY-...". Perhaps it was by accident and not design but this ability was recently lost. This PR makes the system initrd accept resolvable UUIDs for encrypted block devices.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@edwtjo
Copy link
Member Author

edwtjo commented Sep 4, 2018

@volth yes, since that is still a filepath. The title could be better. This covers the usecase where one just writes the UUID label as in Mounting at boot time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants