mpv: Added flag for cddaSupport to play Audio CDs #46035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you split the new option and the sorting into 2 different commits? |
Introduced `cddaSupport` for `mpv` which defaults to false. By enabling
it, `mpv` will be compiled with cdda support (`libcdio{,-paranoia}`) to
play audio CDs.
|
@infinisil: Thanks for your feedback, I divided the commit into two separated ones. |
|
Checked that 7cdb44e changes nothing except ordering and whitespace via `git diff-lines 7cdb44e~1 7cdb44e`
git-diff-lines:
```shell
#!/bin/sh
# Shows diff between + and - sides of git-diff. I.e. shows diff between
# lines that were changed and ignores lines that were moved.
trap 'rm -f "$tmp" "$minustmp" "$plustmp"' 0
tmp=`mktemp git-diff-lines.XXXXXXXX.clock`
minustmp=`mktemp git-diff-lines.XXXXXXXX.minus`
plustmp=`mktemp git-diff-lines.XXXXXXXX.plus`
git diff "$@" | grep -E '^[+-]' > "$tmp"
grep -E '^[-]' "$tmp" | sed 's/^[+-] *//' | sort > "$minustmp"
grep -E '^[+]' "$tmp" | sed 's/^[+-] *//' | sort > "$plustmp"
diff -Nua "$minustmp" "$plustmp" | grep -E '^[-+]'
```
Everything LGTM.
|
|
@GrahamcOfBorg build mpv |
|
Success on x86_64-linux (full log) Attempted: mpv Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: mpv Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: mpv Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced
cddaSupportformpvwhich defaults to false. By enabling it,mpvwill be compiled with cdda support (libcdio{,-paranoia}) to play audio CDs.This commit also resorted the different support options alphabetically.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)