Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geant4 overhaul #46019

Merged
merged 8 commits into from Sep 7, 2018
Merged

geant4 overhaul #46019

merged 8 commits into from Sep 7, 2018

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Sep 3, 2018

Motivation for this change

Update geant4 expression to conform to usual practices used in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: g4py, geant4

Partial log (click to expand)

/nix/store/4pzvkzx7dk1xhpbf2nfrwb0srs07jxjs-g4py-10.4.1
/nix/store/spnwn9wpydfdsla1bmc821ihz6rppfd6-geant4-10.4.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: g4py, geant4

Partial log (click to expand)

/nix/store/wshfnky6z43yhiswvxqpcqffqplqf98g-g4py-10.4.1
/nix/store/33v0xl2snj9lz31a5lcpcaffqg9g175w-geant4-10.4.1

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: g4py, geant4

Partial log (click to expand)

  Apple X11 OpenGL GL/gl.h NOTFOUND
Call Stack (most recent call first):
  cmake/Modules/G4CMakeMain.cmake:64 (include)
  CMakeLists.txt:56 (include)


-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-geant4-10.4.1.drv-0/geant4.10.04.p01/build/CMakeFiles/CMakeOutput.log".
builder for '/nix/store/40hwjki54ysksl1mjhl9hai2sqjq75i4-geant4-10.4.1.drv' failed with exit code 1
error: build of '/nix/store/40hwjki54ysksl1mjhl9hai2sqjq75i4-geant4-10.4.1.drv', '/nix/store/smibv9bp61nzmrdgdcqfl8411q2df62d-g4py-10.4.1.drv' failed

@veprbl veprbl mentioned this pull request Sep 7, 2018
Closed
8 tasks
@veprbl
Copy link
Member Author

veprbl commented Sep 7, 2018

@xeji I think this is a good PR and at very least it doesn't break evaluation. Could you please merge this?

@xeji
Copy link
Contributor

xeji commented Sep 7, 2018

Changes LGTM. But I would limit to platforms.linux as it doesn't look like this will build for Darwin (and I cannot find any evidence it ever did).

What's the difference between this and your previous #40618 ?

@veprbl
Copy link
Member Author

veprbl commented Sep 7, 2018

@xeji No problem, fixed. There is no difference with previous PR.

@xeji
Copy link
Contributor

xeji commented Sep 7, 2018

Just to get it back on page 1, I see 😉

@veprbl
Copy link
Member Author

veprbl commented Sep 7, 2018

4 months...

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: g4py, geant4

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: g4py, geant4

Partial log (click to expand)

shrinking /nix/store/4pzvkzx7dk1xhpbf2nfrwb0srs07jxjs-g4py-10.4.1/lib/Geant4/G4run.so
shrinking /nix/store/4pzvkzx7dk1xhpbf2nfrwb0srs07jxjs-g4py-10.4.1/lib/Geant4/G4intercoms.so
shrinking /nix/store/4pzvkzx7dk1xhpbf2nfrwb0srs07jxjs-g4py-10.4.1/lib/Geant4/G4interface.so
shrinking /nix/store/4pzvkzx7dk1xhpbf2nfrwb0srs07jxjs-g4py-10.4.1/lib/Geant4/G4global.so
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4pzvkzx7dk1xhpbf2nfrwb0srs07jxjs-g4py-10.4.1/lib
patching script interpreter paths in /nix/store/4pzvkzx7dk1xhpbf2nfrwb0srs07jxjs-g4py-10.4.1
checking for references to /build in /nix/store/4pzvkzx7dk1xhpbf2nfrwb0srs07jxjs-g4py-10.4.1...
/nix/store/4pzvkzx7dk1xhpbf2nfrwb0srs07jxjs-g4py-10.4.1
/nix/store/spnwn9wpydfdsla1bmc821ihz6rppfd6-geant4-10.4.1

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: g4py, geant4

Partial log (click to expand)

[ 70%] Building CXX object source/processes/CMakeFiles/G4processes.dir/hadronic/models/particle_hp/src/G4ParticleHPFastLegendre_30.cc.o
[ 70%] Building CXX object source/processes/CMakeFiles/G4processes.dir/hadronic/models/particle_hp/src/G4ParticleHPField.cc.o
[ 70%] Building CXX object source/processes/CMakeFiles/G4processes.dir/hadronic/models/particle_hp/src/G4ParticleHPFieldPoint.cc.o
[ 70%] Building CXX object source/processes/CMakeFiles/G4processes.dir/hadronic/models/particle_hp/src/G4ParticleHPFinalState.cc.o
[ 70%] Building CXX object source/processes/CMakeFiles/G4processes.dir/hadronic/models/particle_hp/src/G4ParticleHPFission.cc.o
[ 70%] Building CXX object source/processes/CMakeFiles/G4processes.dir/hadronic/models/particle_hp/src/G4ParticleHPFissionBaseFS.cc.o
[ 70%] Building CXX object source/processes/CMakeFiles/G4processes.dir/hadronic/models/particle_hp/src/G4ParticleHPFissionData.cc.o
[ 70%] Building CXX object source/processes/CMakeFiles/G4processes.dir/hadronic/models/particle_hp/src/G4ParticleHPFissionFS.cc.o
building of '/nix/store/g57qrm21h1rqwrr43kicvif42g85g9p8-geant4-10.4.1.drv' timed out after 1800 seconds
error: build of '/nix/store/g57qrm21h1rqwrr43kicvif42g85g9p8-geant4-10.4.1.drv', '/nix/store/szyixcb9jdfhgy0kh3qcddsicjxya251-g4py-10.4.1.drv' failed

@xeji
Copy link
Contributor

xeji commented Sep 7, 2018

Let's ignore the timeout, the build succeeded the first time.

@xeji xeji merged commit a60e794 into NixOS:master Sep 7, 2018
@veprbl
Copy link
Member Author

veprbl commented Sep 7, 2018

@xeji Thank you so much!

@veprbl veprbl deleted the pr/geant4_overhaul branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @GrahamcOfBorg @xeji