Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.pytest-fixture-config: disable tests #46021

Merged
merged 1 commit into from Sep 4, 2018
Merged

python.pkgs.pytest-fixture-config: disable tests #46021

merged 1 commit into from Sep 4, 2018

Conversation

andir
Copy link
Member

@andir andir commented Sep 3, 2018 •
edited

Motivation for this change

Tests seem to fail on all recent versions even outside of our build
system. The upstream CI tests seem to somehow succeed but I wasn't able
to reproduce that locally. For not it is probably best to disable them.

/cc @dotlambda, @FRidh (re: #45792 (comment) ), ZHF #45960 (should be pickable as is)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@andir
python.pkgs.pytest-fixture-config: disable tests
e41f924 
Tests seem to fail on all recent versions even outside of our build
system. The upstream CI tests seem to somehow succeed but I wasn't able
to reproduce that locally. For not it is probably best to disable them.
@andir andir requested a review from FRidh as a code owner September 3, 2018 23:45
@xeji
Copy link
Contributor

xeji commented Sep 4, 2018

Let's try bumping to 1.3.1 first: https://github.com/manahl/pytest-plugins/releases
(it's not yet on pypi).

@xeji
Copy link
Contributor

xeji commented Sep 4, 2018

Let's try bumping to 1.3.1 first

Forget it, I tried, same test failure.

@andir
Copy link
Member Author

andir commented Sep 4, 2018 via email

@xeji
Copy link
Contributor

xeji commented Sep 4, 2018

@GrahamcOfBorg build python27Packages.pytest-fixture-config python36Packages.pytest-fixture-config

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.pytest-fixture-config, python36Packages.pytest-fixture-config

Partial log (click to expand)

Successfully installed pytest-fixture-config-1.3.0
/build/pytest-fixture-config-1.3.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6pprfac4c46jvnd8z956jlvm9dm3z85x-python3.6-pytest-fixture-config-1.3.0
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6pprfac4c46jvnd8z956jlvm9dm3z85x-python3.6-pytest-fixture-config-1.3.0/lib
patching script interpreter paths in /nix/store/6pprfac4c46jvnd8z956jlvm9dm3z85x-python3.6-pytest-fixture-config-1.3.0
checking for references to /build in /nix/store/6pprfac4c46jvnd8z956jlvm9dm3z85x-python3.6-pytest-fixture-config-1.3.0...
/nix/store/zvvljrlsb659k67zwh8vdv1c9a5fbb2p-python2.7-pytest-fixture-config-1.3.0
/nix/store/6pprfac4c46jvnd8z956jlvm9dm3z85x-python3.6-pytest-fixture-config-1.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.pytest-fixture-config, python36Packages.pytest-fixture-config

Partial log (click to expand)

Requirement already satisfied: more-itertools>=4.0.0 in /nix/store/001clpn178lvlssv4v9wz4bbc3wcpd54-python3.6-more-itertools-4.3.0/lib/python3.6/site-packages (from pytest->pytest-fixture-config==1.3.0) (4.3.0)
Installing collected packages: pytest-fixture-config
Successfully installed pytest-fixture-config-1.3.0
/private/tmp/nix-build-python3.6-pytest-fixture-config-1.3.0.drv-0/pytest-fixture-config-1.3.0
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/a9fnkxh800wp1kql8dbyhacdh80mcap7-python3.6-pytest-fixture-config-1.3.0/lib
patching script interpreter paths in /nix/store/a9fnkxh800wp1kql8dbyhacdh80mcap7-python3.6-pytest-fixture-config-1.3.0
/nix/store/fx1xrh1ws5cpqiaiick4kpzz7b2zxyml-python2.7-pytest-fixture-config-1.3.0
/nix/store/a9fnkxh800wp1kql8dbyhacdh80mcap7-python3.6-pytest-fixture-config-1.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.pytest-fixture-config, python36Packages.pytest-fixture-config

Partial log (click to expand)

Successfully installed pytest-fixture-config-1.3.0
/build/pytest-fixture-config-1.3.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lc8ynkjiaxlwb2rc5p4qkvm7f108f9gn-python3.6-pytest-fixture-config-1.3.0
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lc8ynkjiaxlwb2rc5p4qkvm7f108f9gn-python3.6-pytest-fixture-config-1.3.0/lib
patching script interpreter paths in /nix/store/lc8ynkjiaxlwb2rc5p4qkvm7f108f9gn-python3.6-pytest-fixture-config-1.3.0
checking for references to /build in /nix/store/lc8ynkjiaxlwb2rc5p4qkvm7f108f9gn-python3.6-pytest-fixture-config-1.3.0...
/nix/store/3yr3xib2fq5xacz8z0kvs12fafa87nrd-python2.7-pytest-fixture-config-1.3.0
/nix/store/lc8ynkjiaxlwb2rc5p4qkvm7f108f9gn-python3.6-pytest-fixture-config-1.3.0

@xeji xeji merged commit d814c98 into NixOS:master Sep 4, 2018
xeji pushed a commit that referenced this pull request Sep 4, 2018
@andir @xeji
python.pkgs.pytest-fixture-config: disable tests (#46021)
2c844ce 
Tests seem to fail on all recent versions even outside of our build
system. The upstream CI tests seem to somehow succeed but I wasn't able
to reproduce that locally. For not it is probably best to disable them.

(cherry picked from commit d814c98)
@xeji
Copy link
Contributor

xeji commented Sep 4, 2018

backported in 2c844ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @xeji @GrahamcOfBorg