Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rdy] fetchFromGitLab: escape "repo" parameter #46027

Closed
wants to merge 2 commits into from
Closed

[rdy] fetchFromGitLab: escape "repo" parameter #46027

wants to merge 2 commits into from

Conversation

teto
Copy link
Member

@teto teto commented Sep 4, 2018 •
edited

While packaging https://gitlab.freedesktop.org/xorg/lib/libxdmcp, I had 404 errors
while trying to fetch:

src = fetchFromGitLab {
domain = "gitlab.freedesktop.org";
owner = "xorg";
repo = "lib/libxdmcp";
rev = "6d1aee0310001eca8f6ded9814a2a70b3a774896";
sha256 = "0rn5xmh6391i9l69y613pjad3pzdilskr2xjfcir1vpk8wprvph3";
};
seems like the / needs to be escaped.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@teto
fetchFromGitLab: escape "repo" parameter
3ac4556 
While packaging https://gitlab.freedesktop.org/xorg/lib/libxdmcp, I had 404 errors
while trying to fetch:

  src = fetchFromGitLab {
     domain = "gitlab.freedesktop.org";
     owner = "xorg";
     repo = "lib/libxdmcp";
     rev = "6d1aee0310001eca8f6ded9814a2a70b3a774896";
     sha256 = "0rn5xmh6391i9l69y613pjad3pzdilskr2xjfcir1vpk8wprvph3";
  };
seems like the / needs to be escaped.
@matthewbauer
Copy link
Member

I just reworked it to resolve the merge conflict. Hope it retains the original meaning. I was wondering if groups or owner could also have the slash?

@teto
Copy link
Member Author

teto commented Sep 30, 2018

I think this was fixed in c3612b9#r220576764. One should now add an extra attribute "group" to address this. I don't know if this has a gitlab meaning but it solves the problem. closing.

@teto teto closed this Sep 30, 2018
@teto teto deleted the fetchfromgitlab branch May 13, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teto @matthewbauer @GrahamcOfBorg