Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

khal: add zsh completion #46034

Merged
merged 1 commit into from Sep 6, 2018
Merged

khal: add zsh completion #46034

merged 1 commit into from Sep 6, 2018

Conversation

teto
Copy link
Member

@teto teto commented Sep 4, 2018

Motivation for this change

seems to work fine :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: khal

Partial log (click to expand)

tests/utils_test.py .................................................... [ 94%]
....                                                                     [ 95%]
tests/vdir_test.py X..                                                   [ 96%]
tests/vtimezone_test.py ...                                              [ 97%]
tests/ui/test_calendarwidget.py ...                                      [ 98%]
tests/ui/test_editor.py ..                                               [ 99%]
tests/ui/test_widgets.py .                                               [100%]

==================== 274 passed, 1 xpassed in 24.46 seconds ====================
/nix/store/bn43lb0g8yddbm8mzjjmasqjv6ibx6bp-khal-0.9.9

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: khal

Partial log (click to expand)


        new_etag = vdir.get_etag_from_file(fpath)

>       assert old_etag != new_etag
E       AssertionError: assert '1536057802146153728.000000000' != '1536057802146153728.000000000'

tests/vdir_test.py:69: AssertionError
============== 1 failed, 273 passed, 1 xfailed in 115.88 seconds ===============
builder for '/nix/store/4psj65a1gazc7i1zzb1fcybahqi7ldv0-khal-0.9.9.drv' failed with exit code 1
error: build of '/nix/store/4psj65a1gazc7i1zzb1fcybahqi7ldv0-khal-0.9.9.drv' failed

@Mic92 Mic92 merged commit b285ea7 into NixOS:master Sep 6, 2018
@teto teto deleted the khal_zsh_completion branch September 6, 2018 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teto @GrahamcOfBorg @Mic92