tensorflow: 1.9.0 -> 1.11.0 #45709
Merged
tensorflow: 1.9.0 -> 1.11.0 #45709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build python3.pkgs.Keras python2.pkgs.Keras |
|
Success on aarch64-linux (full log) Attempted: python3.pkgs.Keras, python2.pkgs.Keras Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: python3.pkgs.Keras, python2.pkgs.Keras Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: python3.pkgs.Keras, python2.pkgs.Keras Partial log (click to expand)
|
|
@GrahamcOfBorg build python3.pkgs.tensorflow python2.pkgs.tensorflow |
|
Success on x86_64-darwin (full log) Attempted: python3.pkgs.tensorflow The following builds were skipped because they don't evaluate on x86_64-darwin: python2.pkgs.tensorflow Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: python3.pkgs.tensorflow, python2.pkgs.tensorflow Partial log (click to expand)
|
symphorien
reviewed
Aug 28, 2018
| @@ -0,0 +1,6 @@ | |||
| { callPackage, lib, ... }: | |||
|
|
|||
| lib.overrideDerivation (callPackage ./generic-v3.nix { | |||
There was a problem hiding this comment.
you should use overrideAttrs instead according to https://nixos.org/nixpkgs/manual/#sec-pkg-overrideDerivation
|
Success on x86_64-linux (full log) Attempted: python3.pkgs.tensorflow, python2.pkgs.tensorflow Partial log (click to expand)
|
|
@symphorien Thanks for your feedback, I have applied your suggestion. |
|
@GrahamcOfBorg build protobuf3_6 python3.pkgs.tensorflow python2.pkgs.tensorflow python3.pkgs.tensorflow-tensorboard python2.pkgs.tensorflow-tensorboard |
FRidh
reviewed
Aug 30, 2018
pkgs/top-level/python-packages.nix
Outdated
| @@ -9863,7 +9863,7 @@ in { | |||
| protobuf = callPackage ../development/python-modules/protobuf { | |||
| disabled = isPyPy; | |||
| doCheck = !isPy3k; | |||
| protobuf = pkgs.protobuf3_5; | |||
| protobuf = pkgs.protobuf3_6; | |||
There was a problem hiding this comment.
This change affects more packages that will going to need to be checked.
|
Success on x86_64-darwin (full log) Attempted: protobuf3_6, python3.pkgs.tensorflow, python3.pkgs.tensorflow-tensorboard, python2.pkgs.tensorflow-tensorboard The following builds were skipped because they don't evaluate on x86_64-darwin: python2.pkgs.tensorflow Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: protobuf3_6, python3.pkgs.tensorflow, python2.pkgs.tensorflow, python3.pkgs.tensorflow-tensorboard, python2.pkgs.tensorflow-tensorboard Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: protobuf3_6, python3.pkgs.tensorflow, python2.pkgs.tensorflow, python3.pkgs.tensorflow-tensorboard, python2.pkgs.tensorflow-tensorboard Partial log (click to expand)
|
This was referenced Sep 25, 2018
GrahamcOfBorg
added
10.rebuild-darwin: 1-10
and removed
10.rebuild-darwin: 11-100
labels
|
Could you remove the old hashes file, otherwise looks fine. |
|
@globin I have removed the old hashes. Also, tensorflow 1.11 was released, so I have updated to that. |
|
@GrahamcOfBorg build python3.pkgs.tensorflow python2.pkgs.tensorflow |
|
Failure on aarch64-linux (full log) Attempted: python3.pkgs.tensorflow, python2.pkgs.tensorflow Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: python3.pkgs.tensorflow The following builds were skipped because they don't evaluate on x86_64-darwin: python2.pkgs.tensorflow Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: python3.pkgs.tensorflow, python2.pkgs.tensorflow Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Upstream update
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)