Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vagrant: mark bundler as system plugin #45693

Merged
merged 1 commit into from Aug 28, 2018
Merged

vagrant: mark bundler as system plugin #45693

merged 1 commit into from Aug 28, 2018

Conversation

aneeshusa
Copy link
Contributor

This will cause Vagrant to use the rubygems version of bundler
without complaint.

Motivation for this change

Great suggestion from @calbrecht in #36880 (comment). Fixes #36880.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@aneeshusa
vagrant: mark bundler as system plugin
2ed25d3 
This will cause Vagrant to use the rubygems version of bundler
without complaint.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vagrant

Partial log (click to expand)

/nix/store/807qag0smkwvb6944cac2dni5dpmbjkr-vagrant-2.1.2/lib/ruby/gems/2.4.0/gems/vagrant-2.1.2/bin/vagrant.orig: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/xkzj19d9rlapr9d6kf8igw8303qp2wfp-ruby-2.4.4/bin/ruby"
/nix/store/807qag0smkwvb6944cac2dni5dpmbjkr-vagrant-2.1.2/lib/ruby/gems/2.4.0/gems/vagrant-2.1.2/bin/vagrant: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/xkzj19d9rlapr9d6kf8igw8303qp2wfp-ruby-2.4.4/bin/ruby"
/nix/store/807qag0smkwvb6944cac2dni5dpmbjkr-vagrant-2.1.2/lib/ruby/gems/2.4.0/gems/vagrant-2.1.2/scripts/website_push_docs.sh: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/807qag0smkwvb6944cac2dni5dpmbjkr-vagrant-2.1.2/lib/ruby/gems/2.4.0/gems/vagrant-2.1.2/scripts/website_push_www.sh: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/807qag0smkwvb6944cac2dni5dpmbjkr-vagrant-2.1.2/lib/ruby/gems/2.4.0/gems/vagrant-2.1.2/scripts/sign.sh: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/807qag0smkwvb6944cac2dni5dpmbjkr-vagrant-2.1.2/lib/ruby/gems/2.4.0/gems/vagrant-2.1.2/.runner.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/807qag0smkwvb6944cac2dni5dpmbjkr-vagrant-2.1.2...
running install tests
Vagrant smoke check passed
/nix/store/807qag0smkwvb6944cac2dni5dpmbjkr-vagrant-2.1.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: vagrant

Partial log (click to expand)

/nix/store/45c0j9j4v7wbnfqnnmirl9f2w90a3mvy-vagrant-2.1.2/lib/ruby/gems/2.4.0/gems/vagrant-2.1.2/scripts/sign.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/45c0j9j4v7wbnfqnnmirl9f2w90a3mvy-vagrant-2.1.2/lib/ruby/gems/2.4.0/gems/vagrant-2.1.2/plugins/provisioners/salt/bootstrap-salt.sh: interpreter directive changed from "/bin/sh -" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh -"
/nix/store/45c0j9j4v7wbnfqnnmirl9f2w90a3mvy-vagrant-2.1.2/lib/ruby/gems/2.4.0/gems/vagrant-2.1.2/plugins/hosts/darwin/scripts/install_virtualbox.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/45c0j9j4v7wbnfqnnmirl9f2w90a3mvy-vagrant-2.1.2/lib/ruby/gems/2.4.0/gems/vagrant-2.1.2/bin/vagrant.orig: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/wky3nf0x34sm90rknmwmn4w54s7j1yrh-ruby-2.4.4/bin/ruby"
/nix/store/45c0j9j4v7wbnfqnnmirl9f2w90a3mvy-vagrant-2.1.2/lib/ruby/gems/2.4.0/gems/vagrant-2.1.2/bin/vagrant: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/wky3nf0x34sm90rknmwmn4w54s7j1yrh-ruby-2.4.4/bin/ruby"
/nix/store/45c0j9j4v7wbnfqnnmirl9f2w90a3mvy-vagrant-2.1.2/lib/ruby/gems/2.4.0/gems/vagrant-2.1.2/.runner.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/45c0j9j4v7wbnfqnnmirl9f2w90a3mvy-vagrant-2.1.2...
running install tests
Vagrant smoke check passed
/nix/store/45c0j9j4v7wbnfqnnmirl9f2w90a3mvy-vagrant-2.1.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: vagrant

Partial log (click to expand)

/nix/store/k0yai04cxhr5zjhqs97ph7jz3av8rcnd-vagrant-2.1.2/lib/ruby/gems/2.4.0/gems/vagrant-2.1.2/bin/vagrant: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/l6w0hkgwf9ry57sqcbq2avs62ggy6ws7-ruby-2.4.4/bin/ruby"
/nix/store/k0yai04cxhr5zjhqs97ph7jz3av8rcnd-vagrant-2.1.2/lib/ruby/gems/2.4.0/gems/vagrant-2.1.2/plugins/provisioners/salt/bootstrap-salt.sh: interpreter directive changed from "/bin/sh -" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh -"
/nix/store/k0yai04cxhr5zjhqs97ph7jz3av8rcnd-vagrant-2.1.2/lib/ruby/gems/2.4.0/gems/vagrant-2.1.2/plugins/hosts/darwin/scripts/install_virtualbox.sh: interpreter directive changed from "/bin/bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/k0yai04cxhr5zjhqs97ph7jz3av8rcnd-vagrant-2.1.2/lib/ruby/gems/2.4.0/gems/vagrant-2.1.2/scripts/sign.sh: interpreter directive changed from "/bin/bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/k0yai04cxhr5zjhqs97ph7jz3av8rcnd-vagrant-2.1.2/lib/ruby/gems/2.4.0/gems/vagrant-2.1.2/scripts/website_push_www.sh: interpreter directive changed from "/bin/bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/k0yai04cxhr5zjhqs97ph7jz3av8rcnd-vagrant-2.1.2/lib/ruby/gems/2.4.0/gems/vagrant-2.1.2/scripts/website_push_docs.sh: interpreter directive changed from "/bin/bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/k0yai04cxhr5zjhqs97ph7jz3av8rcnd-vagrant-2.1.2/lib/ruby/gems/2.4.0/gems/vagrant-2.1.2/.runner.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
running install tests
Vagrant smoke check passed
/nix/store/k0yai04cxhr5zjhqs97ph7jz3av8rcnd-vagrant-2.1.2

@Mic92 Mic92 merged commit 849fb28 into NixOS:master Aug 28, 2018
@Mic92
Copy link
Member

Mic92 commented Aug 28, 2018

Should we backport this?

@aneeshusa aneeshusa deleted the mark-bundler-as-system-plugin-for-vagrant branch January 7, 2022 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aneeshusa @GrahamcOfBorg @Mic92